Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1471126

Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init()

Show all headers | View raw

Am 26.08.2016 20:02, schrieb SF Markus Elfring:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 26 Aug 2016 18:32:53 +0200
> 
> * A multiplication for the size determination of a memory allocation
>   indicated that an array data structure should be processed.
>   Thus use the corresponding function "kmalloc_array".
> 
>   This issue was detected by using the Coccinelle software.
> 
> * Replace the specification of data structures by pointer dereferences
>   to make the corresponding size determination a bit safer according to
>   the Linux coding style convention.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  arch/ia64/sn/kernel/irq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/ia64/sn/kernel/irq.c b/arch/ia64/sn/kernel/irq.c
> index 85d0951..c7f9eea 100644
> --- a/arch/ia64/sn/kernel/irq.c
> +++ b/arch/ia64/sn/kernel/irq.c
> @@ -474,12 +474,12 @@ void __init sn_irq_lh_init(void)
>  {
>  	int i;
>  
> -	sn_irq_lh = kmalloc(sizeof(struct list_head *) * NR_IRQS, GFP_KERNEL);
> +	sn_irq_lh = kmalloc_array(NR_IRQS, sizeof(*sn_irq_lh), GFP_KERNEL);
>  	if (!sn_irq_lh)
>  		panic("SN PCI INIT: Failed to allocate memory for PCI init\n");
>  
>  	for (i = 0; i < NR_IRQS; i++) {
> -		sn_irq_lh[i] = kmalloc(sizeof(struct list_head), GFP_KERNEL);
> +		sn_irq_lh[i] = kmalloc(*sn_irq_lh[i], GFP_KERNEL);

perhaps a sizeof(*sn_irq_lh[i]) is here intended ?

re,
 wh

>  		if (!sn_irq_lh[i])
>  			panic("SN PCI INIT: Failed IRQ memory allocation\n");
>  

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] IA64: Fine-tuning for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 20:10 +0200
  [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 20:10 +0200
    Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() Julia Lawall <julia.lawall@lip6.fr> - 2016-08-26 22:00 +0200
      Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() Joe Perches <joe@perches.com> - 2016-08-26 23:10 +0200
        Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-27 09:10 +0200
          Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() Joe Perches <joe@perches.com> - 2016-08-28 02:50 +0200
            Re: IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-28 09:40 +0200
            Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() Julia Lawall <julia.lawall@lip6.fr> - 2016-08-28 11:30 +0200
              Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() Joe Perches <joe@perches.com> - 2016-08-28 20:40 +0200
      Re: IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-27 08:30 +0200
    Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() kbuild test robot <lkp@intel.com> - 2016-08-26 22:30 +0200
    Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() walter harms <wharms@bfs.de> - 2016-08-27 10:50 +0200
  [PATCH 2/5] IA64-IRQ: Delete unnecessary braces SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 20:20 +0200
    Re: [PATCH 2/5] IA64-IRQ: Delete unnecessary braces kbuild test robot <lkp@intel.com> - 2016-08-26 22:30 +0200
  [PATCH 5/5] ia64/mm/tlb: Delete unnecessary braces SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 20:20 +0200
    Re: [PATCH 5/5] ia64/mm/tlb: Delete unnecessary braces kbuild test robot <lkp@intel.com> - 2016-08-26 22:50 +0200
      Re: ia64/mm/tlb: Delete unnecessary braces SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-27 09:30 +0200
  [PATCH 3/5] ia64/mm/tlb: Fix indentation in ia64_global_tlb_purge() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 20:20 +0200
  [PATCH 4/5] ia64/mm/tlb: Use kmalloc_array() in ia64_itr_entry() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 20:20 +0200

csiph-web