Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1556689

Re: [PATCH] arm64: dts: exynos: Replace small letter of base address/offset on Exynos5433

Path csiph.com!aioe.org!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] arm64: dts: exynos: Replace small letter of base address/offset on Exynos5433
Date Wed, 11 Jan 2017 17:30:01 +0100
Message-ID <sYtWF-In-21@gated-at.bofh.it> (permalink)
References <sYfqG-8og-5@gated-at.bofh.it> <sYfqG-8og-3@gated-at.bofh.it>
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5VSmcZ0xImUZRxcgvUnnkWru2MSpkuJK63EABfS+4O4=; b=pfgGEdt/3WgQxXoxjp9lWRQQiuEgbsAY/QQZlRU5OCEgEtDNewzFqV1Kv3KuqSBieK o9f8AVyKVvs6u3N3qTHB0mjm1on3s3bGKUkUa9MuQFJTRDGtI7qpCZHSygE+r+i0OAwW KG6Ho+LmKRRO73lz9yQHjtohYWBKeZwY7Pu05dN90ijemDN6PbTYY06t2eTZ4cHLWCWh OlknBPLoYOsrtaKOzUPJR4DH6wDTIpP0P+bwq/xZNTtIAAi7wkVWnmK1PP3YruXArD93 VhwWkmyQBjEGDE+A3d2kBHRQEAcyoPTnhgmoMzaapBb3RpBZRJYTJ9uwo3dB3TB0y6AD 4ZVw==
X-Gm-Message-State AIkVDXKrzGFm39+r7QhbyaGHbowFmhkSwUoTPND8XDXVCRxsRx0jNNJvFsvg19nzRfzwdg==
X-Received by 10.194.97.173 with SMTP id eb13mr5892755wjb.76.1484151978507; Wed, 11 Jan 2017 08:26:18 -0800 (PST)
MIME-Version 1.0
Content-Type text/plain; charset=utf-8
Content-Disposition inline
User-Agent Mutt/1.6.2-neo (2016-08-21)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 28
Organization linux.* mail to news gateway
X-Original-Cc kgene@kernel.org, krzk@kernel.org, javier@osg.samsung.com, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, s.nawrocki@samsung.com, m.szyprowski@samsung.com, a.hajda@samsung.com, chanwoo@kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
X-Original-Date Wed, 11 Jan 2017 18:26:13 +0200
X-Original-Message-ID <20170111162613.lxkc7k75f6q3fsz2@kozik-lap>
X-Original-References <CGME20170111005552epcas1p4a1f6ed88022b46544dec4b3801583267@epcas1p4.samsung.com> <1484096148-17120-1-git-send-email-cw00.choi@samsung.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1556689

Show key headers only | View raw

On Wed, Jan 11, 2017 at 09:55:48AM +0900, Chanwoo Choi wrote:
> This patch replaces the small letter of base address, offset and hex value
> with the capital letter to keep the consistency on Exynos5433.
> 
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index abaf6b4d599d..d7ed1a68b6fd 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -231,7 +231,7 @@
>  		compatible = "arm,psci";
>  		method = "smc";
>  		cpu_off = <0x84000002>;
> -		cpu_on = <0xC4000003>;
> +		cpu_on = <0xc4000003>;

There is no point of such "improvements". This is just unnecessary
churn.

Sometimes such things are accepted as part of some bigger work (vide
recent Andrzej's sysmmu for HDMI/TV). But on its own? No sense at all.

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Chanwoo Choi <cw00.choi@samsung.com> - 2017-01-11 02:00 +0100
  Re: [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Andi Shyti <andi.shyti@samsung.com> - 2017-01-11 02:20 +0100
  Re: [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-11 17:30 +0100
    Re: [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-11 22:30 +0100
      Re: [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-12 07:40 +0100
  Re: [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Rob Herring <robh@kernel.org> - 2017-01-11 22:20 +0100
    Re: [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-11 22:40 +0100

csiph-web