Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1556113 > unrolled thread

[PATCH] arm64: dts: exynos: Replace small letter of base address/offset on Exynos5433

Started byChanwoo Choi <cw00.choi@samsung.com>
First post2017-01-11 02:00 +0100
Last post2017-01-11 22:40 +0100
Articles 7 — 5 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Chanwoo Choi <cw00.choi@samsung.com> - 2017-01-11 02:00 +0100
    Re: [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Andi Shyti <andi.shyti@samsung.com> - 2017-01-11 02:20 +0100
    Re: [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-11 17:30 +0100
      Re: [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-11 22:30 +0100
        Re: [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-12 07:40 +0100
    Re: [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Rob Herring <robh@kernel.org> - 2017-01-11 22:20 +0100
      Re: [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-11 22:40 +0100

#1556113 — [PATCH] arm64: dts: exynos: Replace small letter of base address/offset on Exynos5433

FromChanwoo Choi <cw00.choi@samsung.com>
Date2017-01-11 02:00 +0100
Subject[PATCH] arm64: dts: exynos: Replace small letter of base address/offset on Exynos5433
Message-ID<sYfqG-8og-3@gated-at.bofh.it>
This patch replaces the small letter of base address, offset and hex value
with the capital letter to keep the consistency on Exynos5433.

Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index abaf6b4d599d..d7ed1a68b6fd 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -231,7 +231,7 @@
 		compatible = "arm,psci";
 		method = "smc";
 		cpu_off = <0x84000002>;
-		cpu_on = <0xC4000003>;
+		cpu_on = <0xc4000003>;
 	};
 
 	reboot: syscon-reboot {
@@ -753,7 +753,7 @@
 
 		dsi: dsi@13900000 {
 			compatible = "samsung,exynos5433-mipi-dsi";
-			reg = <0x13900000 0xC0>;
+			reg = <0x13900000 0xc0>;
 			interrupts = <GIC_SPI 205 IRQ_TYPE_LEVEL_HIGH>;
 			phys = <&mipi_phy 1>;
 			phy-names = "dsim";
@@ -880,9 +880,9 @@
 			iommus = <&sysmmu_jpeg>;
 		};
 
-		mfc: codec@152E0000 {
+		mfc: codec@152e0000 {
 			compatible = "samsung,exynos5433-mfc";
-			reg = <0x152E0000 0x10000>;
+			reg = <0x152e0000 0x10000>;
 			interrupts = <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>;
 			clock-names = "pclk", "aclk", "aclk_xiu";
 			clocks = <&cmu_mfc CLK_PCLK_MFC>,
@@ -914,7 +914,7 @@
 
 		sysmmu_gscl0: sysmmu@13c80000 {
 			compatible = "samsung,exynos-sysmmu";
-			reg = <0x13C80000 0x1000>;
+			reg = <0x13c80000 0x1000>;
 			interrupts = <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
 			clock-names = "aclk", "pclk";
 			clocks = <&cmu_gscl CLK_ACLK_SMMU_GSCL0>,
@@ -924,7 +924,7 @@
 
 		sysmmu_gscl1: sysmmu@13c90000 {
 			compatible = "samsung,exynos-sysmmu";
-			reg = <0x13C90000 0x1000>;
+			reg = <0x13c90000 0x1000>;
 			interrupts = <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>;
 			clock-names = "aclk", "pclk";
 			clocks = <&cmu_gscl CLK_ACLK_SMMU_GSCL1>,
@@ -934,7 +934,7 @@
 
 		sysmmu_gscl2: sysmmu@13ca0000 {
 			compatible = "samsung,exynos-sysmmu";
-			reg = <0x13CA0000 0x1000>;
+			reg = <0x13ca0000 0x1000>;
 			interrupts = <GIC_SPI 292 IRQ_TYPE_LEVEL_HIGH>;
 			clock-names = "aclk", "pclk";
 			clocks = <&cmu_gscl CLK_ACLK_SMMU_GSCL2>,
-- 
1.9.1

[toc] | [next] | [standalone]

#1556124

FromAndi Shyti <andi.shyti@samsung.com>
Date2017-01-11 02:20 +0100
Message-ID<sYfK1-ig-11@gated-at.bofh.it>
In reply to#1556113
Hi Chanwoo,

> This patch replaces the small letter of base address, offset and hex value
> with the capital letter to keep the consistency on Exynos5433.
> 
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

Reviewed-by: Andi Shyti <andi.shyti@samsung.com>

You will make Krzysztof happy by guessing the correct subject :)

Andi

[toc] | [prev] | [next] | [standalone]

#1556689

FromKrzysztof Kozlowski <krzk@kernel.org>
Date2017-01-11 17:30 +0100
Message-ID<sYtWF-In-21@gated-at.bofh.it>
In reply to#1556113
On Wed, Jan 11, 2017 at 09:55:48AM +0900, Chanwoo Choi wrote:
> This patch replaces the small letter of base address, offset and hex value
> with the capital letter to keep the consistency on Exynos5433.
> 
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index abaf6b4d599d..d7ed1a68b6fd 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -231,7 +231,7 @@
>  		compatible = "arm,psci";
>  		method = "smc";
>  		cpu_off = <0x84000002>;
> -		cpu_on = <0xC4000003>;
> +		cpu_on = <0xc4000003>;

There is no point of such "improvements". This is just unnecessary
churn.

Sometimes such things are accepted as part of some bigger work (vide
recent Andrzej's sysmmu for HDMI/TV). But on its own? No sense at all.

Best regards,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1556948

FromChanwoo Choi <cwchoi00@gmail.com>
Date2017-01-11 22:30 +0100
Message-ID<sYyD0-3As-75@gated-at.bofh.it>
In reply to#1556689
2017-01-12 1:26 GMT+09:00 Krzysztof Kozlowski <krzk@kernel.org>:
> On Wed, Jan 11, 2017 at 09:55:48AM +0900, Chanwoo Choi wrote:
>> This patch replaces the small letter of base address, offset and hex value
>> with the capital letter to keep the consistency on Exynos5433.
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14 +++++++-------
>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>> index abaf6b4d599d..d7ed1a68b6fd 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>> @@ -231,7 +231,7 @@
>>               compatible = "arm,psci";
>>               method = "smc";
>>               cpu_off = <0x84000002>;
>> -             cpu_on = <0xC4000003>;
>> +             cpu_on = <0xc4000003>;
>
> There is no point of such "improvements". This is just unnecessary
> churn.
>
> Sometimes such things are accepted as part of some bigger work (vide
> recent Andrzej's sysmmu for HDMI/TV). But on its own? No sense at all.

Do you mean that this patch is not reasonable? or
The modification of cpu_on property is only not reasonable?

It is simple for the consistency to use the hex value in dts file.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

[toc] | [prev] | [next] | [standalone]

#1557136

FromKrzysztof Kozlowski <krzk@kernel.org>
Date2017-01-12 07:40 +0100
Message-ID<sYHdf-CK-1@gated-at.bofh.it>
In reply to#1556948
On Wed, Jan 11, 2017 at 11:22 PM, Chanwoo Choi <cwchoi00@gmail.com> wrote:
> 2017-01-12 1:26 GMT+09:00 Krzysztof Kozlowski <krzk@kernel.org>:
>> On Wed, Jan 11, 2017 at 09:55:48AM +0900, Chanwoo Choi wrote:
>>> This patch replaces the small letter of base address, offset and hex value
>>> with the capital letter to keep the consistency on Exynos5433.
>>>
>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>> ---
>>>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14 +++++++-------
>>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>>> index abaf6b4d599d..d7ed1a68b6fd 100644
>>> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>>> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>>> @@ -231,7 +231,7 @@
>>>               compatible = "arm,psci";
>>>               method = "smc";
>>>               cpu_off = <0x84000002>;
>>> -             cpu_on = <0xC4000003>;
>>> +             cpu_on = <0xc4000003>;
>>
>> There is no point of such "improvements". This is just unnecessary
>> churn.
>>
>> Sometimes such things are accepted as part of some bigger work (vide
>> recent Andrzej's sysmmu for HDMI/TV). But on its own? No sense at all.
>
> Do you mean that this patch is not reasonable? or
> The modification of cpu_on property is only not reasonable?
>
> It is simple for the consistency to use the hex value in dts file.

The patch is not reasonable (as sent alone).

Best regards,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1556943

FromRob Herring <robh@kernel.org>
Date2017-01-11 22:20 +0100
Message-ID<sYytk-3x3-35@gated-at.bofh.it>
In reply to#1556113
On Wed, Jan 11, 2017 at 09:55:48AM +0900, Chanwoo Choi wrote:
> This patch replaces the small letter of base address, offset and hex value
> with the capital letter to keep the consistency on Exynos5433.

You mean the other way around, right?

> 
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index abaf6b4d599d..d7ed1a68b6fd 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -231,7 +231,7 @@
>  		compatible = "arm,psci";
>  		method = "smc";
>  		cpu_off = <0x84000002>;
> -		cpu_on = <0xC4000003>;
> +		cpu_on = <0xc4000003>;
>  	};
>  
>  	reboot: syscon-reboot {
> @@ -753,7 +753,7 @@
>  
>  		dsi: dsi@13900000 {
>  			compatible = "samsung,exynos5433-mipi-dsi";
> -			reg = <0x13900000 0xC0>;
> +			reg = <0x13900000 0xc0>;
>  			interrupts = <GIC_SPI 205 IRQ_TYPE_LEVEL_HIGH>;
>  			phys = <&mipi_phy 1>;
>  			phy-names = "dsim";
> @@ -880,9 +880,9 @@
>  			iommus = <&sysmmu_jpeg>;
>  		};
>  
> -		mfc: codec@152E0000 {
> +		mfc: codec@152e0000 {
>  			compatible = "samsung,exynos5433-mfc";
> -			reg = <0x152E0000 0x10000>;
> +			reg = <0x152e0000 0x10000>;
>  			interrupts = <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>;
>  			clock-names = "pclk", "aclk", "aclk_xiu";
>  			clocks = <&cmu_mfc CLK_PCLK_MFC>,
> @@ -914,7 +914,7 @@
>  
>  		sysmmu_gscl0: sysmmu@13c80000 {
>  			compatible = "samsung,exynos-sysmmu";
> -			reg = <0x13C80000 0x1000>;
> +			reg = <0x13c80000 0x1000>;
>  			interrupts = <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
>  			clock-names = "aclk", "pclk";
>  			clocks = <&cmu_gscl CLK_ACLK_SMMU_GSCL0>,
> @@ -924,7 +924,7 @@
>  
>  		sysmmu_gscl1: sysmmu@13c90000 {
>  			compatible = "samsung,exynos-sysmmu";
> -			reg = <0x13C90000 0x1000>;
> +			reg = <0x13c90000 0x1000>;
>  			interrupts = <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>;
>  			clock-names = "aclk", "pclk";
>  			clocks = <&cmu_gscl CLK_ACLK_SMMU_GSCL1>,
> @@ -934,7 +934,7 @@
>  
>  		sysmmu_gscl2: sysmmu@13ca0000 {
>  			compatible = "samsung,exynos-sysmmu";
> -			reg = <0x13CA0000 0x1000>;
> +			reg = <0x13ca0000 0x1000>;
>  			interrupts = <GIC_SPI 292 IRQ_TYPE_LEVEL_HIGH>;
>  			clock-names = "aclk", "pclk";
>  			clocks = <&cmu_gscl CLK_ACLK_SMMU_GSCL2>,
> -- 
> 1.9.1
>

[toc] | [prev] | [next] | [standalone]

#1556953

FromChanwoo Choi <cwchoi00@gmail.com>
Date2017-01-11 22:40 +0100
Message-ID<sYyMG-3Dx-11@gated-at.bofh.it>
In reply to#1556943
2017-01-12 6:15 GMT+09:00 Rob Herring <robh@kernel.org>:
> On Wed, Jan 11, 2017 at 09:55:48AM +0900, Chanwoo Choi wrote:
>> This patch replaces the small letter of base address, offset and hex value
>> with the capital letter to keep the consistency on Exynos5433.
>
> You mean the other way around, right?

When I posted the dts patches, I got the comment that small letter is better
for base address/offset. (It doesn’t mean that all dts file in Linux Kernel
have to use the small letter of base address and offset.)

This dts uses the both capital and small letter for each base address/offset.
Almost hex value already uses the small letter. If possible, I hope to use
the one style (small letter).

>
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14 +++++++-------
>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>> index abaf6b4d599d..d7ed1a68b6fd 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>> @@ -231,7 +231,7 @@
>>               compatible = "arm,psci";
>>               method = "smc";
>>               cpu_off = <0x84000002>;
>> -             cpu_on = <0xC4000003>;
>> +             cpu_on = <0xc4000003>;
>>       };
>>
>>       reboot: syscon-reboot {
>> @@ -753,7 +753,7 @@
>>
>>               dsi: dsi@13900000 {
>>                       compatible = "samsung,exynos5433-mipi-dsi";
>> -                     reg = <0x13900000 0xC0>;
>> +                     reg = <0x13900000 0xc0>;
>>                       interrupts = <GIC_SPI 205 IRQ_TYPE_LEVEL_HIGH>;
>>                       phys = <&mipi_phy 1>;
>>                       phy-names = "dsim";
>> @@ -880,9 +880,9 @@
>>                       iommus = <&sysmmu_jpeg>;
>>               };
>>
>> -             mfc: codec@152E0000 {
>> +             mfc: codec@152e0000 {
>>                       compatible = "samsung,exynos5433-mfc";
>> -                     reg = <0x152E0000 0x10000>;
>> +                     reg = <0x152e0000 0x10000>;
>>                       interrupts = <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>;
>>                       clock-names = "pclk", "aclk", "aclk_xiu";
>>                       clocks = <&cmu_mfc CLK_PCLK_MFC>,
>> @@ -914,7 +914,7 @@
>>
>>               sysmmu_gscl0: sysmmu@13c80000 {
>>                       compatible = "samsung,exynos-sysmmu";
>> -                     reg = <0x13C80000 0x1000>;
>> +                     reg = <0x13c80000 0x1000>;
>>                       interrupts = <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
>>                       clock-names = "aclk", "pclk";
>>                       clocks = <&cmu_gscl CLK_ACLK_SMMU_GSCL0>,
>> @@ -924,7 +924,7 @@
>>
>>               sysmmu_gscl1: sysmmu@13c90000 {
>>                       compatible = "samsung,exynos-sysmmu";
>> -                     reg = <0x13C90000 0x1000>;
>> +                     reg = <0x13c90000 0x1000>;
>>                       interrupts = <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>;
>>                       clock-names = "aclk", "pclk";
>>                       clocks = <&cmu_gscl CLK_ACLK_SMMU_GSCL1>,
>> @@ -934,7 +934,7 @@
>>
>>               sysmmu_gscl2: sysmmu@13ca0000 {
>>                       compatible = "samsung,exynos-sysmmu";
>> -                     reg = <0x13CA0000 0x1000>;
>> +                     reg = <0x13ca0000 0x1000>;
>>                       interrupts = <GIC_SPI 292 IRQ_TYPE_LEVEL_HIGH>;
>>                       clock-names = "aclk", "pclk";
>>                       clocks = <&cmu_gscl CLK_ACLK_SMMU_GSCL2>,
>> --
>> 1.9.1
>>



-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web