Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1556689

Re: [PATCH] arm64: dts: exynos: Replace small letter of base address/offset on Exynos5433

From Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] arm64: dts: exynos: Replace small letter of base address/offset on Exynos5433
Date 2017-01-11 17:30 +0100
Message-ID <sYtWF-In-21@gated-at.bofh.it> (permalink)
References <sYfqG-8og-5@gated-at.bofh.it> <sYfqG-8og-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Jan 11, 2017 at 09:55:48AM +0900, Chanwoo Choi wrote:
> This patch replaces the small letter of base address, offset and hex value
> with the capital letter to keep the consistency on Exynos5433.
> 
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index abaf6b4d599d..d7ed1a68b6fd 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -231,7 +231,7 @@
>  		compatible = "arm,psci";
>  		method = "smc";
>  		cpu_off = <0x84000002>;
> -		cpu_on = <0xC4000003>;
> +		cpu_on = <0xc4000003>;

There is no point of such "improvements". This is just unnecessary
churn.

Sometimes such things are accepted as part of some bigger work (vide
recent Andrzej's sysmmu for HDMI/TV). But on its own? No sense at all.

Best regards,
Krzysztof

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Chanwoo Choi <cw00.choi@samsung.com> - 2017-01-11 02:00 +0100
  Re: [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Andi Shyti <andi.shyti@samsung.com> - 2017-01-11 02:20 +0100
  Re: [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-11 17:30 +0100
    Re: [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-11 22:30 +0100
      Re: [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-12 07:40 +0100
  Re: [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Rob Herring <robh@kernel.org> - 2017-01-11 22:20 +0100
    Re: [PATCH] arm64: dts: exynos: Replace small letter of base  address/offset on Exynos5433 Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-11 22:40 +0100

csiph-web