Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1557597

[PATCH 1/5] pinctrl: mvebu: Use kmalloc_array() in mvebu_pinctrl_dt_node_to_map()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 12 Jan 2017 16:00:15 +0100

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/pinctrl/mvebu/pinctrl-mvebu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/mvebu/pinctrl-mvebu.c b/drivers/pinctrl/mvebu/pinctrl-mvebu.c
index b6ec6db78351..c2f74572ac01 100644
--- a/drivers/pinctrl/mvebu/pinctrl-mvebu.c
+++ b/drivers/pinctrl/mvebu/pinctrl-mvebu.c
@@ -398,7 +398,7 @@ static int mvebu_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
 		return 0;
 	}
 
-	*map = kmalloc(nmaps * sizeof(struct pinctrl_map), GFP_KERNEL);
+	*map = kmalloc_array(nmaps, sizeof(**map), GFP_KERNEL);
 	if (*map == NULL) {
 		dev_err(pctl->dev,
 			"cannot allocate pinctrl_map memory for %s\n",
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] pinctrl-mvebu: Fine-tuning for four function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-12 17:40 +0100
  [PATCH 3/5] pinctrl: mvebu: Delete an unnecessary return statement in  mvebu_pinconf_group_dbg_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-12 17:40 +0100
  [PATCH 4/5] pinctrl: mvebu: Use seq_puts() in  mvebu_pinconf_group_dbg_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-12 17:40 +0100
  [PATCH 5/5] pinctrl: mvebu: Use seq_putc() in  mvebu_pinconf_group_dbg_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-12 17:40 +0100
  [PATCH 2/5] pinctrl: mvebu: Delete an error message for a failed  memory allocation in three functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-12 17:40 +0100
  [PATCH 1/5] pinctrl: mvebu: Use kmalloc_array() in  mvebu_pinctrl_dt_node_to_map() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-12 17:40 +0100

csiph-web