Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1557598

Re: [PATCH] crypto: mediatek: don't return garbage err on successful return

From Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups linux.kernel
Subject Re: [PATCH] crypto: mediatek: don't return garbage err on successful return
Date 2017-01-12 17:50 +0100
Message-ID <sYQJz-6gs-3@gated-at.bofh.it> (permalink)
References <sVxk6-6WU-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Jan 03, 2017 at 01:21:22PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> In the case where keylen <= bs mtk_sha_setkey returns an uninitialized
> return value in err.  Fix this by returning 0 instead of err.
> 
> Issue detected by static analysis with cppcheck.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] crypto: mediatek: don't return garbage err on successful  return Herbert Xu <herbert@gondor.apana.org.au> - 2017-01-12 17:50 +0100

csiph-web