Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1557589

[PATCH 3/5] pinctrl: mvebu: Delete an unnecessary return statement in mvebu_pinconf_group_dbg_show()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 3/5] pinctrl: mvebu: Delete an unnecessary return statement in mvebu_pinconf_group_dbg_show()
Date 2017-01-12 17:40 +0100
Message-ID <sYQzU-6d7-23@gated-at.bofh.it> (permalink)
References <sYQzT-6d7-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 12 Jan 2017 16:30:24 +0100

The script "checkpatch.pl" pointed information out like the following.

WARNING: void function return statements are not generally useful

Thus remove such a statement in the affected function.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/pinctrl/mvebu/pinctrl-mvebu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pinctrl/mvebu/pinctrl-mvebu.c b/drivers/pinctrl/mvebu/pinctrl-mvebu.c
index 0618311e75dc..5b49bcda5e79 100644
--- a/drivers/pinctrl/mvebu/pinctrl-mvebu.c
+++ b/drivers/pinctrl/mvebu/pinctrl-mvebu.c
@@ -224,7 +224,6 @@ static void mvebu_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
 		}
 		seq_printf(s, " ]");
 	}
-	return;
 }
 
 static const struct pinconf_ops mvebu_pinconf_ops = {
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/5] pinctrl-mvebu: Fine-tuning for four function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-12 17:40 +0100
  [PATCH 3/5] pinctrl: mvebu: Delete an unnecessary return statement in  mvebu_pinconf_group_dbg_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-12 17:40 +0100
  [PATCH 4/5] pinctrl: mvebu: Use seq_puts() in  mvebu_pinconf_group_dbg_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-12 17:40 +0100
  [PATCH 5/5] pinctrl: mvebu: Use seq_putc() in  mvebu_pinconf_group_dbg_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-12 17:40 +0100
  [PATCH 2/5] pinctrl: mvebu: Delete an error message for a failed  memory allocation in three functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-12 17:40 +0100
  [PATCH 1/5] pinctrl: mvebu: Use kmalloc_array() in  mvebu_pinctrl_dt_node_to_map() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-12 17:40 +0100

csiph-web