Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1557598 > unrolled thread

Re: [PATCH] crypto: mediatek: don't return garbage err on successful return

Started byHerbert Xu <herbert@gondor.apana.org.au>
First post2017-01-12 17:50 +0100
Last post2017-01-12 17:50 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] crypto: mediatek: don't return garbage err on successful  return Herbert Xu <herbert@gondor.apana.org.au> - 2017-01-12 17:50 +0100

#1557598 — Re: [PATCH] crypto: mediatek: don't return garbage err on successful return

FromHerbert Xu <herbert@gondor.apana.org.au>
Date2017-01-12 17:50 +0100
SubjectRe: [PATCH] crypto: mediatek: don't return garbage err on successful return
Message-ID<sYQJz-6gs-3@gated-at.bofh.it>
On Tue, Jan 03, 2017 at 01:21:22PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> In the case where keylen <= bs mtk_sha_setkey returns an uninitialized
> return value in err.  Fix this by returning 0 instead of err.
> 
> Issue detected by static analysis with cppcheck.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web