Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1553791
| From | Chanwoo Choi <cwchoi00@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node |
| Date | 2017-01-08 06:20 +0100 |
| Message-ID | <sXe3D-203-5@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <sWD46-2DX-29@gated-at.bofh.it> <sWKoV-7NO-31@gated-at.bofh.it> <sWL1D-8lb-13@gated-at.bofh.it> <sWL1D-8lb-11@gated-at.bofh.it> <sWYBA-rV-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Andi,
2017-01-07 21:40 GMT+09:00 Andi Shyti <andi@etezian.org>:
> Hi Chanwoo,
>
>> >>> + touchkey@20 {
>> >>> + compatible = "samsung,tm2-touchkey";
>> >>> + reg = <0x20>;
>> >>> + interrupt-parent = <&gpa3>;
>> >>> + interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
>> >>> + vcc-supply = <&ldo32_reg>;
>> >>> + vdd-supply = <&ldo33_reg>;
>> >>> + };
>> >>> +};
>> >>> +
>> >>> &ldo31_reg {
>> >>> regulator-name = "TSP_VDD_1.85V_AP";
>> >>> regulator-min-microvolt = <1850000>;
>>
>> I repiled the touchkey driver against compatible name.
>> Usually, when developing the device driver, we use the specific h/w name
>> but in this patch, the touckey dt node uses the h/w board name instead of
>> original touckhey name.
>
> this should be a device specifically done for the tm2 and we are
> not sure who is the manufacturer of the device. In order to not
As I knew, this touchkey was made by Cypress semiconductor.
But, for more correct information, you may try to find it.
> assign the device to the wrong manufacturer, we preferred calling
> it Samsung as it is in a Samsung device.
As you mentioned, Samsung made not this touchkey device. It is
certainly wrong manufacturer. I have not seen to use the h/w board
name as the peripheral device name.
I don't prefer to use the inaccurate manufacturer and device name.
--
Best Regards,
Chanwoo Choi
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v5 0/5] Add touch key driver support for TM2 Andi Shyti <andi.shyti@samsung.com> - 2017-01-06 14:50 +0100
[PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Andi Shyti <andi.shyti@samsung.com> - 2017-01-06 14:50 +0100
Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-06 15:10 +0100
Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-06 22:40 +0100
Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-06 23:20 +0100
Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Andi Shyti <andi@etezian.org> - 2017-01-07 13:50 +0100
Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-08 06:20 +0100
Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Andi Shyti <andi@etezian.org> - 2017-01-08 06:50 +0100
Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-08 07:10 +0100
Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Andi Shyti <andi@smida.it> - 2017-01-08 07:20 +0100
Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-06 23:20 +0100
[PATCH v5 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong values for ldo23 and ldo25 Andi Shyti <andi.shyti@samsung.com> - 2017-01-06 14:50 +0100
Re: [PATCH v5 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong values for ldo23 and ldo25 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-06 15:10 +0100
[PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other Andi Shyti <andi.shyti@samsung.com> - 2017-01-06 14:50 +0100
Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other Andi Shyti <andi.shyti@samsung.com> - 2017-01-06 15:00 +0100
Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-06 15:20 +0100
Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-06 15:00 +0100
Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-06 15:20 +0100
Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-06 22:30 +0100
csiph-web