Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1552819

Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other

Show all headers | View raw

Hello Krzysztof,

On 01/06/2017 10:49 AM, Krzysztof Kozlowski wrote:
> On Fri, Jan 06, 2017 at 10:43:47PM +0900, Andi Shyti wrote:
>> Currently tm2e dts includes tm2 but there are some differences
>> between the two boards and tm2 has some properties that tm2e
>> doesn't have.
>>
>> That's why it's important to keep the two dts files independent
>> and put all the commonalities in a tm2-common.dtsi file.
>>
>> At the current status the only two differences between the two
>> dts files (besides the board name) are ldo31 and ldo38.
>>
>> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
>> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---

[snip]

 > Beside that it is starting to look good. I didn't find anything else but
> maybe Javier's eagle eye will catch something.
>

I didn't find anything else, the patch looks good to me now.
 
> 
> Best regards,
> Krzysztof
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/5] Add touch key driver support for TM2 Andi Shyti <andi.shyti@samsung.com> - 2017-01-06 14:50 +0100
  [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Andi Shyti <andi.shyti@samsung.com> - 2017-01-06 14:50 +0100
    Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-06 15:10 +0100
    Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-06 22:40 +0100
      Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-06 23:20 +0100
        Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Andi Shyti <andi@etezian.org> - 2017-01-07 13:50 +0100
          Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-08 06:20 +0100
            Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Andi Shyti <andi@etezian.org> - 2017-01-08 06:50 +0100
              Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-08 07:10 +0100
                Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Andi Shyti <andi@smida.it> - 2017-01-08 07:20 +0100
      Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-06 23:20 +0100
  [PATCH v5 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong values for  ldo23 and ldo25 Andi Shyti <andi.shyti@samsung.com> - 2017-01-06 14:50 +0100
    Re: [PATCH v5 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong values  for ldo23 and ldo25 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-06 15:10 +0100
  [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from  each other Andi Shyti <andi.shyti@samsung.com> - 2017-01-06 14:50 +0100
    Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent  from each other Andi Shyti <andi.shyti@samsung.com> - 2017-01-06 15:00 +0100
      Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent  from each other Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-06 15:20 +0100
    Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent  from each other Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-06 15:00 +0100
      Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent  from each other Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-06 15:20 +0100
    Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent  from each other Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-06 22:30 +0100

csiph-web