Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1553790
| From | Derek Robson <robsonde@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] Staging: speakup: styel fix, octal file permissions |
| Date | 2017-01-08 06:10 +0100 |
| Message-ID | <sXdTX-1Ue-3@gated-at.bofh.it> (permalink) |
| References | <sWQE1-3Il-3@gated-at.bofh.it> <sWTLz-5DF-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Jan 07, 2017 at 08:39:45AM +0100, Greg KH wrote: > On Sat, Jan 07, 2017 at 05:11:16PM +1300, Derek Robson wrote: > > Changed file permission to octal style, > > Found using checkpatch > > Typo in your subject line :( > > > > > Signed-off-by: Derek Robson <robsonde@gmail.com> > > --- > > drivers/staging/speakup/kobjects.c | 54 +++++++++++++++++++------------------- > > 1 file changed, 27 insertions(+), 27 deletions(-) > > > > diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c > > index e744aa9730ff..4e7ebc306488 100644 > > --- a/drivers/staging/speakup/kobjects.c > > +++ b/drivers/staging/speakup/kobjects.c > > @@ -865,66 +865,66 @@ static struct kobj_attribute version_attribute = > > __ATTR_RO(version); > > > > static struct kobj_attribute delimiters_attribute = > > - __ATTR(delimiters, S_IWUSR | S_IRUGO, punc_show, punc_store); > > + __ATTR(delimiters, 0644, punc_show, punc_store); > > static struct kobj_attribute ex_num_attribute = > > - __ATTR(ex_num, S_IWUSR | S_IRUGO, punc_show, punc_store); > > + __ATTR(ex_num, 0644, punc_show, punc_store); > > Why not just use __ATTR_RW() for all of these instead? Be much easier > and smaller and is recommended instead of spelling out the mode values > everywhere. It looks like that won't work in this case the handler is reused and not in the standard format of attrName_show. Or have I not understood the use of __ATTR_RW() ? Thanks
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] Staging: speakup: styel fix, octal file permissions Derek Robson <robsonde@gmail.com> - 2017-01-07 05:20 +0100
Re: [PATCH] Staging: speakup: styel fix, octal file permissions Greg KH <gregkh@linuxfoundation.org> - 2017-01-07 08:40 +0100
Re: [PATCH] Staging: speakup: styel fix, octal file permissions Derek Robson <robsonde@gmail.com> - 2017-01-08 06:10 +0100
Re: [PATCH] Staging: speakup: styel fix, octal file permissions Greg KH <gregkh@linuxfoundation.org> - 2017-01-08 12:40 +0100
csiph-web