Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1552378

Re: [PATCH v2] leds: add LED_ON brightness as boolean value

Show all headers | View raw

Hi Andi,

Thanks for the update.

Applied.

On 01/05/2017 03:34 AM, Andi Shyti wrote:
> Some devices do not handle the led brightness or simply don't
> care about it. Conceptually said devices want to just switch on
> or off the led. It is useless in this case to have a 255 range
> of brightness, while just having an LED_ON and LED_OFF improves
> the boolean meaning of the led status.
> 
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> Hi,
> 
> Thanks Pavel and Jacek for your review.
> 
> Differences from V1
> - used explicit assignement of LED_ON in the enum
> - added Pavel's ack
> 
> Andi
> 
>  include/linux/leds.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/leds.h b/include/linux/leds.h
> index 569cb531094c..bb50d0151e75 100644
> --- a/include/linux/leds.h
> +++ b/include/linux/leds.h
> @@ -27,6 +27,7 @@ struct device;
>  
>  enum led_brightness {
>  	LED_OFF		= 0,
> +	LED_ON		= 1,
>  	LED_HALF	= 127,
>  	LED_FULL	= 255,
>  };
> 

-- 
Best regards,
Jacek Anaszewski

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] leds: add LED_ON brightness as boolean value Andi Shyti <andi.shyti@samsung.com> - 2017-01-05 03:50 +0100
  Re: [PATCH v2] leds: add LED_ON brightness as boolean value Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-01-05 23:30 +0100

csiph-web