Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1551586 > unrolled thread

[PATCH v2] leds: add LED_ON brightness as boolean value

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2] leds: add LED_ON brightness as boolean value Andi Shyti <andi.shyti@samsung.com> - 2017-01-05 03:50 +0100
    Re: [PATCH v2] leds: add LED_ON brightness as boolean value Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-01-05 23:30 +0100

#1551586 — [PATCH v2] leds: add LED_ON brightness as boolean value

Some devices do not handle the led brightness or simply don't
care about it. Conceptually said devices want to just switch on
or off the led. It is useless in this case to have a 255 range
of brightness, while just having an LED_ON and LED_OFF improves
the boolean meaning of the led status.

Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
---
Hi,

Thanks Pavel and Jacek for your review.

Differences from V1
- used explicit assignement of LED_ON in the enum
- added Pavel's ack

Andi

 include/linux/leds.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/leds.h b/include/linux/leds.h
index 569cb531094c..bb50d0151e75 100644
--- a/include/linux/leds.h
+++ b/include/linux/leds.h
@@ -27,6 +27,7 @@ struct device;
 
 enum led_brightness {
 	LED_OFF		= 0,
+	LED_ON		= 1,
 	LED_HALF	= 127,
 	LED_FULL	= 255,
 };
-- 
2.11.0

[toc] | [next] | [standalone]

#1552378

Hi Andi,

Thanks for the update.

Applied.

On 01/05/2017 03:34 AM, Andi Shyti wrote:
> Some devices do not handle the led brightness or simply don't
> care about it. Conceptually said devices want to just switch on
> or off the led. It is useless in this case to have a 255 range
> of brightness, while just having an LED_ON and LED_OFF improves
> the boolean meaning of the led status.
> 
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> Hi,
> 
> Thanks Pavel and Jacek for your review.
> 
> Differences from V1
> - used explicit assignement of LED_ON in the enum
> - added Pavel's ack
> 
> Andi
> 
>  include/linux/leds.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/leds.h b/include/linux/leds.h
> index 569cb531094c..bb50d0151e75 100644
> --- a/include/linux/leds.h
> +++ b/include/linux/leds.h
> @@ -27,6 +27,7 @@ struct device;
>  
>  enum led_brightness {
>  	LED_OFF		= 0,
> +	LED_ON		= 1,
>  	LED_HALF	= 127,
>  	LED_FULL	= 255,
>  };
> 

-- 
Best regards,
Jacek Anaszewski

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web