Re: [PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts
Date	2016-12-13 22:10 +0100
Message-ID	<sO2uJ-683-27@gated-at.bofh.it> (permalink)
References	<sMmQV-8h9-3@gated-at.bofh.it> <sMmQV-8h9-1@gated-at.bofh.it> <sNCAi-796-21@gated-at.bofh.it> <sNIcG-25C-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Dec 12, 2016 at 5:24 PM, Milo Kim <woogyom.kim@gmail.com> wrote:
> On 12/13/2016 02:25 AM, Rob Herring wrote:
>>
>> On Fri, Dec 09, 2016 at 03:28:31PM +0900, Milo Kim wrote:
>>>
>>> Interrupt numbers are from the datasheet, so no need to keep them in
>>> the ABI. Use the number in the DT file.
>>
>> I don't see the purpose of ripping this out. The headers have always
>> been for convienence, not whether the values come from the datasheet or
>> not.
>
>
> My understanding is it's a same rule as other interrupt controllers.

Oh yes, that's true. We never use defines for interrupts. In that case:

Acked-by: Rob Herring <robh@kernel.org>

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts Rob Herring <robh@kernel.org> - 2016-12-12 18:30 +0100
  Re: [PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts Milo Kim <woogyom.kim@gmail.com> - 2016-12-13 00:30 +0100
    Re: [PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts Rob Herring <robh@kernel.org> - 2016-12-13 22:10 +0100

csiph-web