Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1540478 > unrolled thread
| Started by | Rob Herring <robh@kernel.org> |
|---|---|
| First post | 2016-12-12 18:30 +0100 |
| Last post | 2016-12-13 22:10 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts Rob Herring <robh@kernel.org> - 2016-12-12 18:30 +0100
Re: [PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts Milo Kim <woogyom.kim@gmail.com> - 2016-12-13 00:30 +0100
Re: [PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts Rob Herring <robh@kernel.org> - 2016-12-13 22:10 +0100
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2016-12-12 18:30 +0100 |
| Subject | Re: [PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts |
| Message-ID | <sNCAi-796-21@gated-at.bofh.it> |
On Fri, Dec 09, 2016 at 03:28:31PM +0900, Milo Kim wrote: > Interrupt numbers are from the datasheet, so no need to keep them in > the ABI. Use the number in the DT file. I don't see the purpose of ripping this out. The headers have always been for convienence, not whether the values come from the datasheet or not. > Signed-off-by: Milo Kim <woogyom.kim@gmail.com> > --- > arch/arm/boot/dts/am335x-bone-common.dtsi | 8 +++----- > include/dt-bindings/mfd/tps65217.h | 26 -------------------------- > 2 files changed, 3 insertions(+), 31 deletions(-) > delete mode 100644 include/dt-bindings/mfd/tps65217.h
[toc] | [next] | [standalone]
| From | Milo Kim <woogyom.kim@gmail.com> |
|---|---|
| Date | 2016-12-13 00:30 +0100 |
| Message-ID | <sNIcG-25C-27@gated-at.bofh.it> |
| In reply to | #1540478 |
On 12/13/2016 02:25 AM, Rob Herring wrote: > On Fri, Dec 09, 2016 at 03:28:31PM +0900, Milo Kim wrote: >> Interrupt numbers are from the datasheet, so no need to keep them in >> the ABI. Use the number in the DT file. > I don't see the purpose of ripping this out. The headers have always > been for convienence, not whether the values come from the datasheet or > not. My understanding is it's a same rule as other interrupt controllers. I'd like to have Arnd's opinion for this. Best regards, Milo
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2016-12-13 22:10 +0100 |
| Message-ID | <sO2uJ-683-27@gated-at.bofh.it> |
| In reply to | #1540737 |
On Mon, Dec 12, 2016 at 5:24 PM, Milo Kim <woogyom.kim@gmail.com> wrote: > On 12/13/2016 02:25 AM, Rob Herring wrote: >> >> On Fri, Dec 09, 2016 at 03:28:31PM +0900, Milo Kim wrote: >>> >>> Interrupt numbers are from the datasheet, so no need to keep them in >>> the ABI. Use the number in the DT file. >> >> I don't see the purpose of ripping this out. The headers have always >> been for convienence, not whether the values come from the datasheet or >> not. > > > My understanding is it's a same rule as other interrupt controllers. Oh yes, that's true. We never use defines for interrupts. In that case: Acked-by: Rob Herring <robh@kernel.org> Rob
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web