Path: csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Rob Herring Newsgroups: linux.kernel Subject: Re: [PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts Date: Tue, 13 Dec 2016 22:10:01 +0100 Message-ID: References: X-Original-To: Milo Kim X-Gm-Message-State: AKaTC01zN7pIHTqpnTor2pmjHpujC7SbmAtAprQgX+Fqkh+HDHvgYz5aIffIm4+FJ1ND3y0HaUZ0AtogKG4Lbg== X-Received: by 10.129.93.87 with SMTP id r84mr104798888ywb.15.1481663384216; Tue, 13 Dec 2016 13:09:44 -0800 (PST) MIME-Version: 1.0 X-Gmail-Original-Message-ID: Content-Type: text/plain; charset=UTF-8 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 20 Organization: linux.* mail to news gateway X-Original-Cc: Arnd Bergmann , Benoit Cousson , Tony Lindgren , Lee Jones , Sebastian Reichel , Dmitry Torokhov , linux-omap , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" X-Original-Date: Tue, 13 Dec 2016 15:09:23 -0600 X-Original-Message-ID: X-Original-References: <20161209062833.5768-1-woogyom.kim@gmail.com> <20161209062833.5768-3-woogyom.kim@gmail.com> <20161212172511.5nj7whzytpkmrk7z@rob-hp-laptop> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1541525 On Mon, Dec 12, 2016 at 5:24 PM, Milo Kim wrote: > On 12/13/2016 02:25 AM, Rob Herring wrote: >> >> On Fri, Dec 09, 2016 at 03:28:31PM +0900, Milo Kim wrote: >>> >>> Interrupt numbers are from the datasheet, so no need to keep them in >>> the ABI. Use the number in the DT file. >> >> I don't see the purpose of ripping this out. The headers have always >> been for convienence, not whether the values come from the datasheet or >> not. > > > My understanding is it's a same rule as other interrupt controllers. Oh yes, that's true. We never use defines for interrupts. In that case: Acked-by: Rob Herring Rob