Re: /drivers/char/Kconfig Bug Kernel Patch

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: /drivers/char/Kconfig Bug Kernel Patch
Date	Tue, 13 Dec 2016 22:40:02 +0100
Message-ID	<sO2XM-6i5-7@gated-at.bofh.it> (permalink)
References	<sO2XM-6i5-9@gated-at.bofh.it>
X-Original-To	Max Bires <jbires@google.com>
User-Agent	KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
X-Provags-ID	V03:K0:C0cvHzadSSTEKI7poohJOYMGSdYOIX9gHaGe5qbn+EPj9/EMrZo Z4xj24TCTFN0nJxPod2q00ir6nUK8yG+GSWed/Xi+g5TYNTAS6gdPvnEIydB0pNQ0lHLUdu Li2onMvSCvaa6bArCz1YAcQpceDNAGAmICWTz7DTw4xQVrVpMTFkqSPrHHriru8rbt0aqB8 QG6iXgQAK77HZCSxrhoOw==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:lzV90zj1Vks=:mFXv3XpA1hboKgG7SB3eDz /dUWfc35Apww3cDO6W1Tkr9HQOi2JCp5nREbtkVCYI7P0sViiNSdO0vYROEuBVP9IOBQdSedG A2MMscKw+z3uurVN405oxrsKwSktsDPskYs7QtnKZCQZZRRc4GTfqlM1YIsXJSEOfXyw1EgRJ ieYNO9pcmwu5GXFwLT1UxRZ8YsCtusyqDHnsG/jXkRQks9SwTWlu1GR73y1z2fO1DSXa0N7TR 4ZsPKGvI9zVOAoEgZ6h+D17f4aZOK0Jdz6aF5s581ujc/H5lPIbtBiXkW8U+q2qDDdurRx94k pk8Rr6T1gA7fD5tycwismBJcZYJcvhC74AiGuqxpXQ2Mn+xZ8q7Glyw3+aRbqYD0oR+C+mlrX BTfTOC0q3xeruty8ROovWqMHlKfy3xb6lrkBW8qzpuueLA46plHJsJv6lBx+zhMzQdcxdcRVg m8+Rm6KElg4G98QtqwXG+y7ATt9FFsZToxQ3OM1OMuynQ1txPU+L57khOKmliejEL6/Utye4K kRDWWCKjMRY9eei8D8eWo3ivgQu2/sg+z13BRTZaEz3cdo8n3lQOVJVXEIjOKnTsGlW3ysIfS rxfDmWkoeviyx6zDHDIRLgfrjyGvcAhy1JdikLbUrWsqTKGT0ONomZ/yp1ILUCHWd3lQgJUjU 7AWqoAicDwtnXQn1WCyLxGmuOLMJUY0tu/7Q9i53yY0zZ43H2Q9zWwTo8UVBMdnFd531uDNcH +S3uSdsuKtoWOwTE
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	21
Organization	linux.* mail to news gateway
X-Original-Cc	gregkh@linuxfoundation.org, josh@joshtriplett.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 13 Dec 2016 22:37:58 +0100
X-Original-Message-ID	<25312310.aENfjP0Zdi@wuerfel>
X-Original-References	<CALVgH4QHDYw=j4k2iogL4FTvLXMExi6GqrskQoQ0bxP1MjN0Ew@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1541535

Show key headers only | View raw

On Tuesday, December 13, 2016 1:30:39 PM CET Max Bires wrote:
> While trying to turn off the port device in defconfig, I ran into a bug
> caused by the fact that the Kconfig for port didn't have a string after the
> bool declaration. I fixed this in the attached patch (though I figure the
> description might need tuning up). Let me know if there's anything else I
> need to do.

The change looks reasonable, however there are a few things to improve
to get the patch applied:

- clarify that the current behavior is not a bug, but was done intentionally.
  Making the option user-visible would help avoid a potential attack vector
  and make the kernel smaller, both of which are useful.

- remove the "Change-id" line from the submission, it has no meaning in 
  an upstream kernel

- send the patch inline rather than as an attachment, this is usually done
  with git-send-email.

	Arnd

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: /drivers/char/Kconfig Bug Kernel Patch Arnd Bergmann <arnd@arndb.de> - 2016-12-13 22:40 +0100
  Re: /drivers/char/Kconfig Bug Kernel Patch Josh Triplett <josh@joshtriplett.org> - 2016-12-13 23:50 +0100
  Re: /drivers/char/Kconfig Bug Kernel Patch Max Bires <jbires@google.com> - 2016-12-14 00:00 +0100
    Re: /drivers/char/Kconfig Bug Kernel Patch Greg KH <gregkh@linuxfoundation.org> - 2016-12-14 01:10 +0100

csiph-web