Re: /drivers/char/Kconfig Bug Kernel Patch

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: /drivers/char/Kconfig Bug Kernel Patch
Date	2016-12-13 22:40 +0100
Message-ID	<sO2XM-6i5-7@gated-at.bofh.it> (permalink)
References	<sO2XM-6i5-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday, December 13, 2016 1:30:39 PM CET Max Bires wrote:
> While trying to turn off the port device in defconfig, I ran into a bug
> caused by the fact that the Kconfig for port didn't have a string after the
> bool declaration. I fixed this in the attached patch (though I figure the
> description might need tuning up). Let me know if there's anything else I
> need to do.

The change looks reasonable, however there are a few things to improve
to get the patch applied:

- clarify that the current behavior is not a bug, but was done intentionally.
  Making the option user-visible would help avoid a potential attack vector
  and make the kernel smaller, both of which are useful.

- remove the "Change-id" line from the submission, it has no meaning in 
  an upstream kernel

- send the patch inline rather than as an attachment, this is usually done
  with git-send-email.

	Arnd

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: /drivers/char/Kconfig Bug Kernel Patch Arnd Bergmann <arnd@arndb.de> - 2016-12-13 22:40 +0100
  Re: /drivers/char/Kconfig Bug Kernel Patch Josh Triplett <josh@joshtriplett.org> - 2016-12-13 23:50 +0100
  Re: /drivers/char/Kconfig Bug Kernel Patch Max Bires <jbires@google.com> - 2016-12-14 00:00 +0100
    Re: /drivers/char/Kconfig Bug Kernel Patch Greg KH <gregkh@linuxfoundation.org> - 2016-12-14 01:10 +0100

csiph-web