Re: [PATCH 1/1] staging: lustre: lnet: fix improper return value

From	Oleg Drokin <oleg.drokin@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] staging: lustre: lnet: fix improper return value
Date	2016-12-05 23:50 +0100
Message-ID	<sLaf7-27k-7@gated-at.bofh.it> (permalink)
References	<sKi53-1eT-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Dec 3, 2016, at 7:52 AM, Pan Bian wrote:

> From: Pan Bian <bianpan2016@163.com>
> 
> At the end of function lstcon_group_info(), "return 0" seems improper.
> It may be better to return the value of rc.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188811
> 
> Signed-off-by: Pan Bian <bianpan2016@163.com>

Acked-by: Oleg Drokin <oleg.drokin@intel.com>

> ---
> drivers/staging/lustre/lnet/selftest/console.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c
> index a0fcbf3..9a7c41a 100644
> --- a/drivers/staging/lustre/lnet/selftest/console.c
> +++ b/drivers/staging/lustre/lnet/selftest/console.c
> @@ -820,7 +820,7 @@
> 
> 	lstcon_group_decref(grp);
> 
> -	return 0;
> +	return rc;
> }
> 
> static int
> -- 
> 1.9.1
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] staging: lustre: lnet: fix improper return value Pan Bian <bianpan201602@163.com> - 2016-12-03 14:00 +0100
  Re: [PATCH 1/1] staging: lustre: lnet: fix improper return value Oleg Drokin <oleg.drokin@intel.com> - 2016-12-05 23:50 +0100

csiph-web