Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1536498
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/4] rtc: mcp795: fix month write resetting date to 1. |
| Date | 2016-12-05 23:50 +0100 |
| Message-ID | <sLaf7-27k-19@gated-at.bofh.it> (permalink) |
| References | <sL1lv-52x-1@gated-at.bofh.it> <sL1lv-52x-15@gated-at.bofh.it> <sL3nk-6eM-27@gated-at.bofh.it> <sL9M5-1XN-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 05/12/2016 at 23:16:55 +0100, Emil Bartczak wrote :
> > > +static int mcp795_start_oscillator(struct device *dev)
> > > +{
> > > + return mcp795_rtcc_set_bits(dev, MCP795_REG_SECONDS,
> > > + MCP795_ST_BIT, MCP795_ST_BIT);
> >
> > You probably want to restore EXTOSC to its previous value here.
> I came to the conclusion that it is better to remove clearing of bit EXTOSC in function mcp795_stop_oscillator.
> Because regarding datasheet, after power up the RTC chip (or reset) that bit has value 0.
> What do you think?
>
That is one way but maybe some people are setting that bit in the
bootloader. It doesn't matter much. If you are not using the feature,
let it that way. If anybody needs it at some point they can still send a
patch :)
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] Provides bug fixes for rtc-mcp795.c Emil Bartczak <emilbart@gmail.com> - 2016-12-05 14:20 +0100
[PATCH 1/4] rtc: mcp795: fix invalid month setting. Emil Bartczak <emilbart@gmail.com> - 2016-12-05 14:20 +0100
Re: [PATCH 1/4] rtc: mcp795: fix invalid month setting. Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-12-05 16:20 +0100
Re: [PATCH 1/4] rtc: mcp795: fix invalid month setting. Emil Bartczak <emilbart@gmail.com> - 2016-12-05 23:10 +0100
Re: [PATCH 1/4] rtc: mcp795: fix invalid month setting. Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-12-05 23:20 +0100
Re: [PATCH 1/4] rtc: mcp795: fix invalid month setting. Emil Bartczak <emilbart@gmail.com> - 2016-12-05 23:40 +0100
[PATCH 3/4] rtc: mcp795: fix month write resetting date to 1. Emil Bartczak <emilbart@gmail.com> - 2016-12-05 14:20 +0100
Re: [PATCH 3/4] rtc: mcp795: fix month write resetting date to 1. Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-12-05 16:30 +0100
Re: [PATCH 3/4] rtc: mcp795: fix month write resetting date to 1. Emil Bartczak <emilbart@gmail.com> - 2016-12-05 23:20 +0100
Re: [PATCH 3/4] rtc: mcp795: fix month write resetting date to 1. Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-12-05 23:50 +0100
[PATCH 2/4] rtc: mcp795: fix time range difference between linux and RTC chip Emil Bartczak <emilbart@gmail.com> - 2016-12-05 14:20 +0100
[PATCH 4/4] rtc: mcp795: use bcd2bin/bin2bcd. Emil Bartczak <emilbart@gmail.com> - 2016-12-05 14:20 +0100
Re: [PATCH 4/4] rtc: mcp795: use bcd2bin/bin2bcd. Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-12-05 16:30 +0100
csiph-web