Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1535390 > unrolled thread
| Started by | Pan Bian <bianpan201602@163.com> |
|---|---|
| First post | 2016-12-03 14:00 +0100 |
| Last post | 2016-12-05 23:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/1] staging: lustre: lnet: fix improper return value Pan Bian <bianpan201602@163.com> - 2016-12-03 14:00 +0100
Re: [PATCH 1/1] staging: lustre: lnet: fix improper return value Oleg Drokin <oleg.drokin@intel.com> - 2016-12-05 23:50 +0100
| From | Pan Bian <bianpan201602@163.com> |
|---|---|
| Date | 2016-12-03 14:00 +0100 |
| Subject | [PATCH 1/1] staging: lustre: lnet: fix improper return value |
| Message-ID | <sKi53-1eT-1@gated-at.bofh.it> |
From: Pan Bian <bianpan2016@163.com> At the end of function lstcon_group_info(), "return 0" seems improper. It may be better to return the value of rc. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188811 Signed-off-by: Pan Bian <bianpan2016@163.com> --- drivers/staging/lustre/lnet/selftest/console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c index a0fcbf3..9a7c41a 100644 --- a/drivers/staging/lustre/lnet/selftest/console.c +++ b/drivers/staging/lustre/lnet/selftest/console.c @@ -820,7 +820,7 @@ lstcon_group_decref(grp); - return 0; + return rc; } static int -- 1.9.1
[toc] | [next] | [standalone]
| From | Oleg Drokin <oleg.drokin@intel.com> |
|---|---|
| Date | 2016-12-05 23:50 +0100 |
| Message-ID | <sLaf7-27k-7@gated-at.bofh.it> |
| In reply to | #1535390 |
On Dec 3, 2016, at 7:52 AM, Pan Bian wrote: > From: Pan Bian <bianpan2016@163.com> > > At the end of function lstcon_group_info(), "return 0" seems improper. > It may be better to return the value of rc. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188811 > > Signed-off-by: Pan Bian <bianpan2016@163.com> Acked-by: Oleg Drokin <oleg.drokin@intel.com> > --- > drivers/staging/lustre/lnet/selftest/console.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c > index a0fcbf3..9a7c41a 100644 > --- a/drivers/staging/lustre/lnet/selftest/console.c > +++ b/drivers/staging/lustre/lnet/selftest/console.c > @@ -820,7 +820,7 @@ > > lstcon_group_decref(grp); > > - return 0; > + return rc; > } > > static int > -- > 1.9.1 >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web