Re: [PATCH] usb:hub: readibility and consistency in coding style

From	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb:hub: readibility and consistency in coding style
Date	2016-11-30 13:10 +0100
Message-ID	<sJbS2-5UT-17@gated-at.bofh.it> (permalink)
References	<sJbyF-5yf-5@gated-at.bofh.it> <sJbyF-5yf-7@gated-at.bofh.it> <sJbIm-5Bx-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Nov 30, 2016 at 11:51:39AM +0000, Atul Raj wrote:
> It is suggested to keep braces if there is a comment in if case as
> comment also takes a line.
> ---
>  drivers/usb/core/hub.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Ok, this is getting to be a joke.

Take a few days off, relax, then try to send a patch that works to
yourself first, and run it through scripts/checkpatch.pl to verify that
it really is correct.  Hint, this one isn't at all.

Then, maybe you should start doing some work on drivers/staging/ first,
which is where new developers should start out to work out all of these
issues so you don't bother the other developers who are working on
adding new features and fixing bugs.

Also, why are you including a ton of people who have nothing to do with
usb patches on this one?

good luck,

greg k-h

Thread

[PATCH] usb:hub: readibility and consistency in coding style Atul Raj <atul.r@samsung.com> - 2016-11-30 13:00 +0100
  Re: [PATCH] usb:hub: readibility and consistency in coding style "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> - 2016-11-30 13:10 +0100
  RE: Re: [PATCH] usb:hub: readibility and consistency in coding style Atul Raj <atul.r@samsung.com> - 2016-11-30 13:40 +0100
    Re: Re: [PATCH] usb:hub: readibility and consistency in coding style "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> - 2016-11-30 15:00 +0100

csiph-web