Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1533267

RE: Re: [PATCH] usb:hub: readibility and consistency in coding style

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Greg,

I am so happy to get a mail from you and I am really sorry Greg that I disappointed you.
I will take utmost care in future.
I will send you correct patch in sometime.
for your ques
"Also, why are you including a ton of people who have nothing to do with
usb patches on this one?"

I got the name of people from get_maintainer.pl
from now I will include only you.
is it ok??


one more thing in another mail you replied to me as
On Wed, Nov 30, 2016 at 11:40:28AM +0000, Atul Raj wrote:
>  changes in v2
>         - added braces as suggested.

Why is this here?

> 
>  drivers/usb/core/hub.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

do you disagree with viresh comment of braces???

Thanks for your words.


Your Fan
Atul Raj


>
 > On Wed, Nov 30, 2016 at 11:51:39AM +0000, Atul Raj wrote:
 > > It is suggested to keep braces if there is a comment in if case as
 > > comment also takes a line.
 > > ---
 > >  drivers/usb/core/hub.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
 >
 > Ok, this is getting to be a joke.
 >
 > Take a few days off, relax, then try to send a patch that works to
 > yourself first, and run it through scripts/checkpatch.pl to verify that
 > it really is correct.  Hint, this one isn't at all.
 >
 > Then, maybe you should start doing some work on drivers/staging/ first,
 > which is where new developers should start out to work out all of these
 > issues so you don't bother the other developers who are working on
 > adding new features and fixing bugs.
 >
 > Also, why are you including a ton of people who have nothing to do with
 > usb patches on this one?
 >
 > good luck,
 >
 > greg k-h
 

 
 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb:hub: readibility and consistency in coding style Atul Raj <atul.r@samsung.com> - 2016-11-30 13:00 +0100
  Re: [PATCH] usb:hub: readibility and consistency in coding style "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> - 2016-11-30 13:10 +0100
  RE: Re: [PATCH] usb:hub: readibility and consistency in coding style Atul Raj <atul.r@samsung.com> - 2016-11-30 13:40 +0100
    Re: Re: [PATCH] usb:hub: readibility and consistency in coding style "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> - 2016-11-30 15:00 +0100

csiph-web