Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1533262

Re: [PATCH] IIO: Change msleep to usleep_range for small msecs

From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] IIO: Change msleep to usleep_range for small msecs
Date 2016-11-30 13:20 +0100
Message-ID <sJc1H-61D-13@gated-at.bofh.it> (permalink)
References <sHC0h-17I-3@gated-at.bofh.it> <sI5lD-3eJ-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sun, Nov 27, 2016 at 11:51 AM, Jonathan Cameron <jic23@kernel.org> wrote:
> On 26/11/16 03:47, Aniroop Mathur wrote:

[bmp280.c]

>>       /* Wait to make sure we started up properly */
>> -     mdelay(data->start_up_time);
>> +     usleep_range(data->start_up_time, data->start_up_time + 100);
>
> As this in probe I doubt we really care.  Could just set it longer to shut up the warnings.
> Still would like some input from say Linus on this...

Hm, I don't think it's a big issue... this works too it just looks overworked.

On the runtime_resume() path we use msleep() instead which I guess is why
it is not changed in this patch, but they have the same purpose.

Yours,
Linus Walleij

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] IIO: Change msleep to usleep_range for small msecs Aniroop Mathur <a.mathur@samsung.com> - 2016-11-26 04:40 +0100
  Re: [PATCH] IIO: Change msleep to usleep_range for small msecs Jonathan Cameron <jic23@kernel.org> - 2016-11-27 12:00 +0100
    Re: [PATCH] IIO: Change msleep to usleep_range for small msecs Linus Walleij <linus.walleij@linaro.org> - 2016-11-30 13:20 +0100
      Re: [PATCH] IIO: Change msleep to usleep_range for small msecs Aniroop Mathur <aniroop.mathur@gmail.com> - 2016-12-02 20:10 +0100
    Re: [PATCH] IIO: Change msleep to usleep_range for small msecs Lars-Peter Clausen <lars@metafoo.de> - 2016-11-30 14:40 +0100
    RE: Re: [PATCH] IIO: Change msleep to usleep_range for small msecs Aniroop Mathur <a.mathur@samsung.com> - 2016-11-30 15:50 +0100
      Re: Re: [PATCH] IIO: Change msleep to usleep_range for small msecs Aniroop Mathur <aniroop.mathur@gmail.com> - 2016-12-02 20:10 +0100
        Re: [PATCH] IIO: Change msleep to usleep_range for small msecs Jonathan Cameron <jic23@kernel.org> - 2016-12-03 15:40 +0100
          Re: [PATCH] IIO: Change msleep to usleep_range for small msecs Aniroop Mathur <aniroop.mathur@gmail.com> - 2016-12-03 16:50 +0100

csiph-web