Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1532886

Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue

Show all headers | View raw

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 29 Nov 2016 16:43:20 -0800

> On 11/29/2016 04:38 PM, David Miller wrote:
>> From: Jerome Brunet <jbrunet@baylibre.com>
>> Date: Mon, 28 Nov 2016 10:46:45 +0100
>> 
>>> This patchset fixes an issue with the OdroidC2 board (DWMAC + RTL8211F).
>>> The platform seems to enter LPI on the Rx path too often while performing
>>> relatively high TX transfer. This eventually break the link (both Tx and
>>> Rx), and require to bring the interface down and up again to get the Rx
>>> path working again.
>>>
>>> The root cause of this issue is not fully understood yet but disabling EEE
>>> advertisement on the PHY prevent this feature to be negotiated.
>>> With this change, the link is stable and reliable, with the expected
>>> throughput performance.
>>>
>>> The patchset adds options in the generic phy driver to disable EEE
>>> advertisement, through device tree. The way it is done is very similar
>>> to the handling of the max-speed property.
>> 
>> Patches 1-3 applied to net-next, thanks.
> 
> Meh, there was a v4 submitted shortly after, and I objected to the whole
> idea of using that kind of Device Tree properties to disable EEE, we can
> send reverts though..

Sorry, I lost this in all the discussion, I can revert.

Just send me a revert of the entire merge commit
a152c91889556df17ca6d8ea134fb2cb4ac9f893 with a short
description of why and I'll apply it.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue Jerome Brunet <jbrunet@baylibre.com> - 2016-11-28 10:50 +0100
  [PATCH net-next v3 1/4] net: phy: add an option to disable EEE advertisement Jerome Brunet <jbrunet@baylibre.com> - 2016-11-28 10:50 +0100
    Re: [PATCH net-next v3 1/4] net: phy: add an option to disable EEE advertisement Yegor Yefremov <yegorslists@googlemail.com> - 2016-11-28 11:40 +0100
    Re: [PATCH net-next v3 1/4] net: phy: add an option to disable EEE  advertisement Andreas Färber <afaerber@suse.de> - 2016-11-28 13:30 +0100
  [PATCH net-next v3 3/4] dt: bindings: add ethernet phy eee-broken-modes option documentation Jerome Brunet <jbrunet@baylibre.com> - 2016-11-28 10:50 +0100
    Re: [PATCH net-next v3 3/4] dt: bindings: add ethernet phy  eee-broken-modes option documentation Andreas Färber <afaerber@suse.de> - 2016-11-28 13:30 +0100
  [PATCH net-next v3 4/4] ARM64: dts: meson: odroidc2: disable advertisement EEE for GbE. Jerome Brunet <jbrunet@baylibre.com> - 2016-11-28 10:50 +0100
    Re: [PATCH net-next v3 4/4] ARM64: dts: meson: odroidc2: disable  advertisement EEE for GbE. Andreas Färber <afaerber@suse.de> - 2016-11-28 13:40 +0100
      Re: [PATCH net-next v3 4/4] ARM64: dts: meson: odroidc2: disable  advertisement EEE for GbE. Jerome Brunet <jbrunet@baylibre.com> - 2016-11-28 13:50 +0100
  Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue Neil Armstrong <narmstrong@baylibre.com> - 2016-11-28 14:50 +0100
  Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue David Miller <davem@davemloft.net> - 2016-11-30 01:40 +0100
    Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue Florian Fainelli <f.fainelli@gmail.com> - 2016-11-30 01:50 +0100
      Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue Florian Fainelli <f.fainelli@gmail.com> - 2016-11-30 02:20 +0100
      Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue David Miller <davem@davemloft.net> - 2016-11-30 02:20 +0100

csiph-web