Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1531285

Re: [PATCH net-next v3 4/4] ARM64: dts: meson: odroidc2: disable advertisement EEE for GbE.

Show all headers | View raw

Am 28.11.2016 um 10:46 schrieb Jerome Brunet:
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> index e6e3491d48a5..5624714d2b16 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> @@ -46,6 +46,7 @@
>  
>  #include "meson-gxbb.dtsi"
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/net/mdio.h>
>  
>  / {
>  	compatible = "hardkernel,odroid-c2", "amlogic,meson-gxbb";
> @@ -98,3 +99,18 @@
>  	pinctrl-0 = <&i2c_a_pins>;
>  	pinctrl-names = "default";
>  };
> +
> +&ethmac {
> +	phy-handle = <&eth_phy0>;
> +
> +	mdio {
> +		compatible = "snps,dwmac-mdio";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		eth_phy0: ethernet-phy@0 {
> +			reg = <0>;
> +			eee-broken-modes = <MDIO_EEE_1000T>;
> +		};
> +	};
> +};

I've tested this hand-applied because it applies to neither amlogic
v4.10/integ nor linux-next.git and will conflict if applied through the
net-next tree.

Note that there already is an &ethmac node that you should be extending
rather than duplicating:

&ethmac {
	status = "okay";
	pinctrl-0 = <&eth_rgmii_pins>;
	pinctrl-names = "default";
};

If you or your colleagues could please fix the sort order of the nodes
to be alphabetical again (ethmac after i2c_A here; between uart_A and ir
in-tree) this wouldn't happen so easily again.

I therefore suggest to not apply this patch 4/4 through net-next but
through the amlogic tree instead.

Thanks,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue Jerome Brunet <jbrunet@baylibre.com> - 2016-11-28 10:50 +0100
  [PATCH net-next v3 1/4] net: phy: add an option to disable EEE advertisement Jerome Brunet <jbrunet@baylibre.com> - 2016-11-28 10:50 +0100
    Re: [PATCH net-next v3 1/4] net: phy: add an option to disable EEE advertisement Yegor Yefremov <yegorslists@googlemail.com> - 2016-11-28 11:40 +0100
    Re: [PATCH net-next v3 1/4] net: phy: add an option to disable EEE  advertisement Andreas Färber <afaerber@suse.de> - 2016-11-28 13:30 +0100
  [PATCH net-next v3 3/4] dt: bindings: add ethernet phy eee-broken-modes option documentation Jerome Brunet <jbrunet@baylibre.com> - 2016-11-28 10:50 +0100
    Re: [PATCH net-next v3 3/4] dt: bindings: add ethernet phy  eee-broken-modes option documentation Andreas Färber <afaerber@suse.de> - 2016-11-28 13:30 +0100
  [PATCH net-next v3 4/4] ARM64: dts: meson: odroidc2: disable advertisement EEE for GbE. Jerome Brunet <jbrunet@baylibre.com> - 2016-11-28 10:50 +0100
    Re: [PATCH net-next v3 4/4] ARM64: dts: meson: odroidc2: disable  advertisement EEE for GbE. Andreas Färber <afaerber@suse.de> - 2016-11-28 13:40 +0100
      Re: [PATCH net-next v3 4/4] ARM64: dts: meson: odroidc2: disable  advertisement EEE for GbE. Jerome Brunet <jbrunet@baylibre.com> - 2016-11-28 13:50 +0100
  Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue Neil Armstrong <narmstrong@baylibre.com> - 2016-11-28 14:50 +0100
  Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue David Miller <davem@davemloft.net> - 2016-11-30 01:40 +0100
    Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue Florian Fainelli <f.fainelli@gmail.com> - 2016-11-30 01:50 +0100
      Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue Florian Fainelli <f.fainelli@gmail.com> - 2016-11-30 02:20 +0100
      Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue David Miller <davem@davemloft.net> - 2016-11-30 02:20 +0100

csiph-web