Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1531159

[PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue

From Jerome Brunet <jbrunet@baylibre.com>
Newsgroups linux.kernel
Subject [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue
Date 2016-11-28 10:50 +0100
Message-ID <sIqJr-lL-5@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


This patchset fixes an issue with the OdroidC2 board (DWMAC + RTL8211F).
The platform seems to enter LPI on the Rx path too often while performing
relatively high TX transfer. This eventually break the link (both Tx and
Rx), and require to bring the interface down and up again to get the Rx
path working again.

The root cause of this issue is not fully understood yet but disabling EEE
advertisement on the PHY prevent this feature to be negotiated.
With this change, the link is stable and reliable, with the expected
throughput performance.

The patchset adds options in the generic phy driver to disable EEE
advertisement, through device tree. The way it is done is very similar
to the handling of the max-speed property.

Changes since V2: [2]
 - Rename "eee-advert-disable" to "eee-broken-modes" to make the intended
   purpose of this option clear (flag broken configuration, not a
   configuration option)
 - Add DT bindings constants so the DT configuration is more user friendly
 - Submit to net-next instead of net.

Changes since V1: [1]
 - Disable the advertisement of EEE in the generic code instead of the
   realtek driver.

[1] : http://lkml.kernel.org/r/1479220154-25851-1-git-send-email-jbrunet@baylibre.com
[2] : http://lkml.kernel.org/r/1479742524-30222-1-git-send-email-jbrunet@baylibre.com


Jerome Brunet (4):
  net: phy: add an option to disable EEE advertisement
  dt-bindings: net: add EEE capability constants
  dt: bindings: add ethernet phy eee-broken-modes option documentation
  ARM64: dts: meson: odroidc2: disable advertisement EEE for GbE.

 Documentation/devicetree/bindings/net/phy.txt      |  2 +
 .../arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 16 +++++
 drivers/net/phy/phy.c                              |  3 +
 drivers/net/phy/phy_device.c                       | 80 +++++++++++++++++++---
 include/dt-bindings/net/mdio.h                     | 19 +++++
 include/linux/phy.h                                |  3 +
 6 files changed, 114 insertions(+), 9 deletions(-)
 create mode 100644 include/dt-bindings/net/mdio.h

-- 
2.7.4

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue Jerome Brunet <jbrunet@baylibre.com> - 2016-11-28 10:50 +0100
  [PATCH net-next v3 1/4] net: phy: add an option to disable EEE advertisement Jerome Brunet <jbrunet@baylibre.com> - 2016-11-28 10:50 +0100
    Re: [PATCH net-next v3 1/4] net: phy: add an option to disable EEE advertisement Yegor Yefremov <yegorslists@googlemail.com> - 2016-11-28 11:40 +0100
    Re: [PATCH net-next v3 1/4] net: phy: add an option to disable EEE  advertisement Andreas Färber <afaerber@suse.de> - 2016-11-28 13:30 +0100
  [PATCH net-next v3 3/4] dt: bindings: add ethernet phy eee-broken-modes option documentation Jerome Brunet <jbrunet@baylibre.com> - 2016-11-28 10:50 +0100
    Re: [PATCH net-next v3 3/4] dt: bindings: add ethernet phy  eee-broken-modes option documentation Andreas Färber <afaerber@suse.de> - 2016-11-28 13:30 +0100
  [PATCH net-next v3 4/4] ARM64: dts: meson: odroidc2: disable advertisement EEE for GbE. Jerome Brunet <jbrunet@baylibre.com> - 2016-11-28 10:50 +0100
    Re: [PATCH net-next v3 4/4] ARM64: dts: meson: odroidc2: disable  advertisement EEE for GbE. Andreas Färber <afaerber@suse.de> - 2016-11-28 13:40 +0100
      Re: [PATCH net-next v3 4/4] ARM64: dts: meson: odroidc2: disable  advertisement EEE for GbE. Jerome Brunet <jbrunet@baylibre.com> - 2016-11-28 13:50 +0100
  Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue Neil Armstrong <narmstrong@baylibre.com> - 2016-11-28 14:50 +0100
  Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue David Miller <davem@davemloft.net> - 2016-11-30 01:40 +0100
    Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue Florian Fainelli <f.fainelli@gmail.com> - 2016-11-30 01:50 +0100
      Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue Florian Fainelli <f.fainelli@gmail.com> - 2016-11-30 02:20 +0100
      Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue David Miller <davem@davemloft.net> - 2016-11-30 02:20 +0100

csiph-web