Re: [PATCH] netdevice: fix sparse warning for HARD_TX_LOCK

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] netdevice: fix sparse warning for HARD_TX_LOCK
Date	Sun, 27 Nov 2016 21:50:01 +0100
Message-ID	<sIeyB-R6-5@gated-at.bofh.it> (permalink)
References	<sGUsi-6pb-31@gated-at.bofh.it>
X-Mailer	Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO)
MIME-Version	1.0
Content-Type	Text/Plain; charset=us-ascii
Content-Transfer-Encoding	7bit
X-Greylist	Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 27 Nov 2016 11:45:16 -0800 (PST)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	16
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
X-Original-Date	Sun, 27 Nov 2016 15:44:39 -0500 (EST)
X-Original-Message-ID	<20161127.154439.845919200540679482.davem@davemloft.net>
X-Original-References	<1479963754-24105-1-git-send-email-mst@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1530925

Show key headers only | View raw

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Thu, 24 Nov 2016 07:04:08 +0200

> sparse warns about context imbalance in any code
> that uses HARD_TX_LOCK/UNLOCK - this is because it's
> unable to determine that flags don't change so
> lock and unlock are paired.
> 
> Seems easy enough to fix by adding __acquire/__release
> calls.
> 
> With this patch af_packet.c is now sparse-clean,
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Applied to net-next, thanks.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] netdevice: fix sparse warning for HARD_TX_LOCK David Miller <davem@davemloft.net> - 2016-11-27 21:50 +0100

csiph-web