Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1530925 > unrolled thread

Re: [PATCH] netdevice: fix sparse warning for HARD_TX_LOCK

Started byDavid Miller <davem@davemloft.net>
First post2016-11-27 21:50 +0100
Last post2016-11-27 21:50 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] netdevice: fix sparse warning for HARD_TX_LOCK David Miller <davem@davemloft.net> - 2016-11-27 21:50 +0100

#1530925 — Re: [PATCH] netdevice: fix sparse warning for HARD_TX_LOCK

FromDavid Miller <davem@davemloft.net>
Date2016-11-27 21:50 +0100
SubjectRe: [PATCH] netdevice: fix sparse warning for HARD_TX_LOCK
Message-ID<sIeyB-R6-5@gated-at.bofh.it>
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Thu, 24 Nov 2016 07:04:08 +0200

> sparse warns about context imbalance in any code
> that uses HARD_TX_LOCK/UNLOCK - this is because it's
> unable to determine that flags don't change so
> lock and unlock are paired.
> 
> Seems easy enough to fix by adding __acquire/__release
> calls.
> 
> With this patch af_packet.c is now sparse-clean,
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Applied to net-next, thanks.

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web