Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Baolin Wang <baolin.wang@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement
Date	Tue, 29 Nov 2016 03:30:01 +0100
Message-ID	<sIGlb-293-3@gated-at.bofh.it> (permalink)
References	<sH0o2-1XY-33@gated-at.bofh.it> <sInBT-6Us-1@gated-at.bofh.it> <sIoxY-7ud-15@gated-at.bofh.it> <sIoRj-7B7-15@gated-at.bofh.it> <sIvSO-3L8-7@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RtywRwDOhomGsgTcoSs595kkDGa8q5Gos36XMJtzcv8=; b=ZxOUj2xxVwkPRueYSLVOLmGzluKISTqHJTJyCTsyEdTMbm7xVACUlsWQ7caGGCri+6 HdnzUYlRsV82CW33VPYhLWVeQyVZhK5+WzlCP3DsFwBdyKJ4UudwG9FDZT5PvKmcqOhs Y33JkZCt+2lZZARU139c1/ar5jDHAwiIbDJhM=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RtywRwDOhomGsgTcoSs595kkDGa8q5Gos36XMJtzcv8=; b=k6YKNjFDtMUqntF8l/Z9iVBgPSnRT3149igt9Fq/JTrYu3kpJ5etQh10YokNqsoOZS 3JzglY8bO4DbFIAhEGe+ujotQt6izrO+6xJ6giRkyFaEhOLAo2LQi/YSWnFaHXDSXr91 TtHT7v42sk1fNtRDQ981xqWJRWpZzL325kq58acXZ7wFnnjow1zQo0fSRgxBAPDtLIvV mcwepyYM3fCtZz+xPxm+tz/szXoNx3qaqgIeymUpIUNG6RbYcXNq18DsttH0jCziEklq F1h8bfXvExC8Zu8tTkbjFtvwfGTernfQCGVx4VXv874SqgbnFW7fXaFT/ZIaqxpTqRU/ gQNQ==
X-Gm-Message-State	AKaTC00G6tfe4ZSTF7nLGfc806Pplp8VttqbQUCPK+s7xg4WaQy10wQZDUbjq53Ed6zacB2MMOOA9Hnw3D/8KG10
X-Received	by 10.129.51.204 with SMTP id z195mr28024045ywz.352.1480386449950; Mon, 28 Nov 2016 18:27:29 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	45
Organization	linux.* mail to news gateway
X-Original-Cc	Greg KH <gregkh@linuxfoundation.org>, mathias.nyman@intel.com, USB <linux-usb@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, Mark Brown <broonie@kernel.org>
X-Original-Date	Tue, 29 Nov 2016 10:27:29 +0800
X-Original-Message-ID	<CAMz4kuKMw8ejQRP=SXaJT3me0z_jZ_52ZdqzvAsRDKDcY3Tx9Q@mail.gmail.com>
X-Original-References	<5788dd3650bed67a1551e209847ecdf732eb745b.1479986112.git.baolin.wang@linaro.org> <CAMz4ku+uRfCNg9xh37UCtYy2_F6R+LC4GxHibqpZzCyA59vwGA@mail.gmail.com> <20161128072157.GA17504@kroah.com> <CAMz4kuJ7fqvD+WWYWc4M1PQxYP2xGA9Jkc6Gxz0FdfNzaxN19g@mail.gmail.com> <583C49EA.5060504@linux.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1531866

Show key headers only | View raw

On 28 November 2016 at 23:14, Mathias Nyman
<mathias.nyman@linux.intel.com> wrote:
> On 28.11.2016 09:41, Baolin Wang wrote:
>>
>> On 28 November 2016 at 15:21, Greg KH <gregkh@linuxfoundation.org> wrote:
>>>
>>> On Mon, Nov 28, 2016 at 02:29:25PM +0800, Baolin Wang wrote:
>>>>
>>>> Hi Mathias,
>>>>
>>>> On 24 November 2016 at 19:16, Baolin Wang <baolin.wang@linaro.org>
>>>> wrote:
>>>>>
>>>>> Since these 'return' statements are not generally useful in void
>>>>> function, remove them. Also remove one unuseful 'break' statement
>>>>> in xhci_setup_addressable_virt_dev() function.
>>>>>
>>>>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>>>>> ---
>>>>> Changes since v1:
>>>>>   - Add description of removing 'break' statement in commitlog.
>>>>> ---
>>>>
>>>>
>>>> Could you apply this patch if there are no other comments? Thanks.
>>>
>>>
>>> Less than a week response for a simple cleanup patch?  Why the rush and
>>> pressure?  Relax, this really isn't an important patch...
>>
>>
>> I am sorry for the pressure, I just thought it is one simple cleanup
>> patch. It is okay for me to wait for.
>>
>
> Looks ok.
>
> If it applies I'll send it forward to usb-next after 4.10-rc1,
> It should end up in 4.11

Thanks.

-- 
Baolin.wang
Best Regards

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement Baolin Wang <baolin.wang@linaro.org> - 2016-11-28 07:30 +0100
  Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break'  statement Greg KH <gregkh@linuxfoundation.org> - 2016-11-28 08:30 +0100
    Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement Baolin Wang <baolin.wang@linaro.org> - 2016-11-28 08:50 +0100
      Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break'  statement Mathias Nyman <mathias.nyman@linux.intel.com> - 2016-11-28 16:20 +0100
        Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement Baolin Wang <baolin.wang@linaro.org> - 2016-11-29 03:30 +0100

csiph-web