Re: [PATCH v3 1/2] Input - soc_button_array: use gpio_is_valid()

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/2] Input - soc_button_array: use gpio_is_valid()
Date	2016-11-25 20:40 +0100
Message-ID	<sHuvL-4HW-11@gated-at.bofh.it> (permalink)
References	<sHrHz-2XN-3@gated-at.bofh.it> <sHrHz-2XN-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Nov 25, 2016 at 05:36:41PM +0100, Benjamin Tissoires wrote:
> gpio_keys will later use gpio_is_valid(). To match the actual
> behavior, we should use it here too.
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Applied, thank you.

> 
> ---
> 
> no changes in v3
> 
> Changes in v2:
> - fixed gpio_is_valid(gpio) -> !gpio_is_valid(gpio)
> ---
>  drivers/input/misc/soc_button_array.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
> index c14b827..bbd433c 100644
> --- a/drivers/input/misc/soc_button_array.c
> +++ b/drivers/input/misc/soc_button_array.c
> @@ -17,6 +17,7 @@
>  #include <linux/acpi.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/gpio_keys.h>
> +#include <linux/gpio.h>
>  #include <linux/platform_device.h>
>  
>  /*
> @@ -92,7 +93,7 @@ soc_button_device_create(struct platform_device *pdev,
>  			continue;
>  
>  		gpio = soc_button_lookup_gpio(&pdev->dev, info->acpi_index);
> -		if (gpio < 0)
> +		if (!gpio_is_valid(gpio))
>  			continue;
>  
>  		gpio_keys[n_buttons].type = info->event_type;
> -- 
> 2.7.4
> 

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/2] small fixes for soc_button_array Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-11-25 17:40 +0100
  [PATCH v3 2/2] Input - soc_button_array: bail out earlier if gpiod_count is null Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-11-25 17:40 +0100
    Re: [PATCH v3 2/2] Input - soc_button_array: bail out earlier if  gpiod_count is null Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-11-25 20:40 +0100
  [PATCH v3 1/2] Input - soc_button_array: use gpio_is_valid() Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-11-25 17:40 +0100
    Re: [PATCH v3 1/2] Input - soc_button_array: use gpio_is_valid() Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-11-25 20:40 +0100

csiph-web