Re: [PATCH v3 2/2] Input - soc_button_array: bail out earlier if gpiod_count is null

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/2] Input - soc_button_array: bail out earlier if gpiod_count is null
Date	2016-11-25 20:40 +0100
Message-ID	<sHuvM-4HW-15@gated-at.bofh.it> (permalink)
References	<sHrHz-2XN-3@gated-at.bofh.it> <sHrHz-2XN-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Nov 25, 2016 at 05:36:42PM +0100, Benjamin Tissoires wrote:
> The PNP0C40 device of the Surface 3 doesn't have any GPIO attached to it.
> Instead of trying to access the GPIO, request the count beforehand and
> bail out if it is null or if an error is returned.
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
> 
> no changes in v3
> 
> changes in v2:
> - hunk moved down for better integration with later patches
> ---
>  drivers/input/misc/soc_button_array.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
> index bbd433c..5467d04 100644
> --- a/drivers/input/misc/soc_button_array.c
> +++ b/drivers/input/misc/soc_button_array.c
> @@ -167,6 +167,11 @@ static int soc_button_probe(struct platform_device *pdev)
>  
>  	button_info = (struct soc_button_info *)id->driver_data;
>  
> +	if (gpiod_count(&pdev->dev, KBUILD_MODNAME) <= 0) {
> +		dev_info(&pdev->dev, "no GPIO attached, ignoring...\n");

Changed this to dev_dbg() and applied, thank you.

> +		return -ENODEV;
> +	}
> +
>  	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
>  	if (!priv)
>  		return -ENOMEM;
> -- 
> 2.7.4
> 

-- 
Dmitry

Thread

[PATCH v3 0/2] small fixes for soc_button_array Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-11-25 17:40 +0100
  [PATCH v3 2/2] Input - soc_button_array: bail out earlier if gpiod_count is null Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-11-25 17:40 +0100
    Re: [PATCH v3 2/2] Input - soc_button_array: bail out earlier if  gpiod_count is null Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-11-25 20:40 +0100
  [PATCH v3 1/2] Input - soc_button_array: use gpio_is_valid() Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-11-25 17:40 +0100
    Re: [PATCH v3 1/2] Input - soc_button_array: use gpio_is_valid() Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-11-25 20:40 +0100

csiph-web