Re: [PATCH 1/2] stacktrace: fix print_stack_trace printing timestamp twice

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] stacktrace: fix print_stack_trace printing timestamp twice
Date	2016-11-25 20:40 +0100
Message-ID	<sHuvM-4HW-25@gated-at.bofh.it> (permalink)
References	<sBkpr-5em-7@gated-at.bofh.it> <sBkps-5em-45@gated-at.bofh.it> <sHsNk-3Ai-19@gated-at.bofh.it> <sHsNk-3Ai-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2016-11-25 at 18:40 +0100, Dmitry Vyukov wrote:
> But should we add KERN_CONT to print_ip_sym instead of duplicating it
> everywhere? Or add print_ip_sym_cont?

There are only a couple dozen uses of print_ip_sym.

It might be better to use "[<%p>] %pS" directly
everywhere and remove print_ip_sym instead to
avoid the KERN_CONT and avoid all possible
interleaved output.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] stacktrace: fix print_stack_trace printing timestamp twice Dmitry Vyukov <dvyukov@google.com> - 2016-11-25 18:50 +0100
  Re: [PATCH 1/2] stacktrace: fix print_stack_trace printing  timestamp twice Joe Perches <joe@perches.com> - 2016-11-25 20:40 +0100

csiph-web