Re: [PATCH] regulator: twl6030: add dependency on OF

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] regulator: twl6030: add dependency on OF
Date	2016-11-25 14:20 +0100
Message-ID	<sHoA1-129-17@gated-at.bofh.it> (permalink)
References	<sHjqF-65B-5@gated-at.bofh.it> <sHoqm-YR-45@gated-at.bofh.it> <sHoA1-129-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Nov 25, 2016 at 03:09:43PM +0200, Nicolae Rosia wrote:
> On Fri, Nov 25, 2016 at 3:03 PM, Mark Brown <broonie@kernel.org> wrote:

> >> -             .of_match_table = of_match_ptr(twl_of_match),
> >> +             .of_match_table = twl_of_match,

> > This buys us nothing, it's not going to make any practical difference
> > but on the other hand it costs nothing to have it there either.  The
> > only impact I can see this having is causing someone doing a cut'n'paste
> > to miss the of_match_ptr() out.

> I did this because I received a comment on another patch [0].

OK, but that still doesn't really explain what the benefit is!

Thread

[PATCH] regulator: twl6030: add dependency on OF Nicolae Rosia <Nicolae_Rosia@mentor.com> - 2016-11-25 08:50 +0100
  Re: [PATCH] regulator: twl6030: add dependency on OF Mark Brown <broonie@kernel.org> - 2016-11-25 14:10 +0100
    Re: [PATCH] regulator: twl6030: add dependency on OF Mark Brown <broonie@kernel.org> - 2016-11-25 14:20 +0100
    Re: [PATCH] regulator: twl6030: add dependency on OF Nicolae Rosia <nicolae.rosia.oss@gmail.com> - 2016-11-25 14:20 +0100

csiph-web