Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1530225

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

Show all headers | View raw

Hi,

On Wed, Nov 23, 2016 at 12:03:28PM -0800, Eric Dumazet wrote:
>On Wed, Nov 23, 2016 at 10:21 AM, Brian Starkey <brian.starkey@arm.com> wrote:
>
>> This patch didn't help.
>>
>> I did get some new traces though - I've attached the diff for the
>> trace_printks I added.
>>
>> Before 4cd13c21b207:
>> https://drive.google.com/open?id=0B8siaK6ZjvEwcEtOeFQzTmY0Nnc
>> After 4cd13c21b207:
>> https://drive.google.com/open?id=0B8siaK6ZjvEwZnQ4MVg1d3d1Tm8
>>
>> It looks like the difference is that after 4cd13c21b207 the RX softirq
>> isn't running, and RX interrupts don't call softirq_raise anymore -
>> presumably because there's one pending, but I didn't have time to
>> track that down to a code-path.
>>
>> Cheers,
>> -Brian
>>
>
>Hi Brian
>
>Looks like netif_rx() drops the incoming packets then ?
>
>Maybe netif_running() is not happy :(
>
>Could you trace netif_rx() return value (NET_RX_SUCCESS or NET_RX_DROP)

Some packets are dropped, but not very many:

   $ grep NET_RX_SUCCESS trace_netif_rx.txt | wc -l
   14399
   $ grep NET_RX_DROP trace_netif_rx.txt | wc -l
   22

Without the ksoftirqd change there were zero NET_RX_DROPs.

-Brian

>
>Thanks !

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let  ksoftirqd do its job" Brian Starkey <brian.starkey@arm.com> - 2016-11-16 15:00 +0100
  Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let  ksoftirqd do its job" Eric Dumazet <edumazet@google.com> - 2016-11-16 17:00 +0100
    Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let  ksoftirqd do its job" Brian Starkey <brian.starkey@arm.com> - 2016-11-16 19:10 +0100
      Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let  ksoftirqd do its job" Eric Dumazet <edumazet@google.com> - 2016-11-16 19:50 +0100
        Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let  ksoftirqd do its job" Brian Starkey <brian.starkey@arm.com> - 2016-11-16 22:10 +0100
          Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let  ksoftirqd do its job" Brian Starkey <brian.starkey@arm.com> - 2016-11-17 18:10 +0100
            Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let  ksoftirqd do its job" Thomas Gleixner <tglx@linutronix.de> - 2016-11-18 01:50 +0100
              Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let  ksoftirqd do its job" Brian Starkey <brian.starkey@arm.com> - 2016-11-18 21:30 +0100
              Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let  ksoftirqd do its job" Brian Starkey <brian.starkey@arm.com> - 2016-11-22 11:40 +0100
                Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let  ksoftirqd do its job" Eric Dumazet <edumazet@google.com> - 2016-11-22 15:30 +0100
                Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let  ksoftirqd do its job" Brian Starkey <brian.starkey@arm.com> - 2016-11-22 16:30 +0100
                Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let  ksoftirqd do its job" Eric Dumazet <edumazet@google.com> - 2016-11-22 17:20 +0100
                Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let  ksoftirqd do its job" Brian Starkey <brian.starkey@arm.com> - 2016-11-23 19:30 +0100
                Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let  ksoftirqd do its job" Eric Dumazet <edumazet@google.com> - 2016-11-23 21:10 +0100
                Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let  ksoftirqd do its job" Brian Starkey <brian.starkey@arm.com> - 2016-11-25 14:20 +0100
          Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let  ksoftirqd do its job" Eric Dumazet <edumazet@google.com> - 2016-11-17 18:10 +0100

csiph-web