Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1530213

Re: [PATCH] regulator: twl6030: add dependency on OF

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Nov 25, 2016 at 09:43:35AM +0200, Nicolae Rosia wrote:

> This driver was converted to device tree only,
> add dependency on OF symbol and drop of_match_ptr

These are two different changes :(

>  config REGULATOR_TWL4030
>  	tristate "TI TWL4030/TWL5030/TWL6030/TPS659x0 PMIC"
>  	depends on TWL4030_CORE
> +	depends on OF

This should be OF || COMPILE_TEST so people can still get build coverage
without DT.

> --- a/drivers/regulator/twl6030-regulator.c
> +++ b/drivers/regulator/twl6030-regulator.c
> @@ -773,7 +773,7 @@ static struct platform_driver twlreg_driver = {
>  	 */
>  	.driver  = {
>  		.name  = "twl6030_reg",
> -		.of_match_table = of_match_ptr(twl_of_match),
> +		.of_match_table = twl_of_match,

This buys us nothing, it's not going to make any practical difference
but on the other hand it costs nothing to have it there either.  The
only impact I can see this having is causing someone doing a cut'n'paste
to miss the of_match_ptr() out.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: twl6030: add dependency on OF Nicolae Rosia <Nicolae_Rosia@mentor.com> - 2016-11-25 08:50 +0100
  Re: [PATCH] regulator: twl6030: add dependency on OF Mark Brown <broonie@kernel.org> - 2016-11-25 14:10 +0100
    Re: [PATCH] regulator: twl6030: add dependency on OF Mark Brown <broonie@kernel.org> - 2016-11-25 14:20 +0100
    Re: [PATCH] regulator: twl6030: add dependency on OF Nicolae Rosia <nicolae.rosia.oss@gmail.com> - 2016-11-25 14:20 +0100

csiph-web