Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1529688

Re: [PATCH 1/1 linux-next] ext4: add compatibility flag check

From Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups linux.kernel
Subject Re: [PATCH 1/1 linux-next] ext4: add compatibility flag check
Date 2016-11-24 21:40 +0100
Message-ID <sH8Yh-7HV-3@gated-at.bofh.it> (permalink)
References <sH8bT-76f-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Nov 24, 2016 at 08:47:41PM +0100, Fabian Frederick wrote:
> data=journal mount option should disable O_DIRECT access
> (See Documentation/filesystems/ext4.txt) but open operations
> using O_CREAT|O_RDWR|O_DIRECT|O_SYNC have no warning in return and file is being
> created. This patch adds vfs super_operations compatibility flag function
> returning -EPERM in such a case.

Why not simply check it in ->open()?  Occam's Razor and all such...

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/1 linux-next] ext4: add compatibility flag check Fabian Frederick <fabf@skynet.be> - 2016-11-24 20:50 +0100
  Re: [PATCH 1/1 linux-next] ext4: add compatibility flag check Al Viro <viro@ZenIV.linux.org.uk> - 2016-11-24 21:40 +0100
    Re: [PATCH 1/1 linux-next] ext4: add compatibility flag check Fabian Frederick <fabf@skynet.be> - 2016-11-24 22:50 +0100
  Re: [PATCH 1/1 linux-next] ext4: add compatibility flag check Theodore Ts'o <tytso@mit.edu> - 2016-11-25 06:30 +0100
    Re: [PATCH 1/1 linux-next] ext4: add compatibility flag check Fabian Frederick <fabf@skynet.be> - 2016-11-25 07:20 +0100

csiph-web