Re: [PATCH 1/1 linux-next] ext4: add compatibility flag check

From	Fabian Frederick <fabf@skynet.be>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1 linux-next] ext4: add compatibility flag check
Date	2016-11-25 07:20 +0100
Message-ID	<sHi1z-5nW-3@gated-at.bofh.it> (permalink)
References	<sH8bT-76f-9@gated-at.bofh.it> <sHhfb-4MD-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


> On 25 November 2016 at 06:26 Theodore Ts'o <tytso@mit.edu> wrote:
>
>
> On Thu, Nov 24, 2016 at 08:47:41PM +0100, Fabian Frederick wrote:
> > data=journal mount option should disable O_DIRECT access
> > (See Documentation/filesystems/ext4.txt) but open operations
> > using O_CREAT|O_RDWR|O_DIRECT|O_SYNC have no warning in return and file is
> > being
> > created. This patch adds vfs super_operations compatibility flag function
> > returning -EPERM in such a case.
> >
> > Signed-off-by: Fabian Frederick <fabf@skynet.be>
>
> The general practice by most file systems in Linux (for better or for
> worse) is to silently fall back to buffered I/O instead of failing the
> O_DIRECT open.  Feel free to try to convince linux-fsdevel otherwise,
> but that is the general and historical consensus of Linux file system
> developers.
>
> Cheers,

Thanks a lot Ted, I'll have a closer look at vfs/ext4 documentation and add some
details if required.

Regards,
Fabian

>
>                                       - Ted

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1 linux-next] ext4: add compatibility flag check Fabian Frederick <fabf@skynet.be> - 2016-11-24 20:50 +0100
  Re: [PATCH 1/1 linux-next] ext4: add compatibility flag check Al Viro <viro@ZenIV.linux.org.uk> - 2016-11-24 21:40 +0100
    Re: [PATCH 1/1 linux-next] ext4: add compatibility flag check Fabian Frederick <fabf@skynet.be> - 2016-11-24 22:50 +0100
  Re: [PATCH 1/1 linux-next] ext4: add compatibility flag check Theodore Ts'o <tytso@mit.edu> - 2016-11-25 06:30 +0100
    Re: [PATCH 1/1 linux-next] ext4: add compatibility flag check Fabian Frederick <fabf@skynet.be> - 2016-11-25 07:20 +0100

csiph-web