[PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS
Date	2016-11-23 14:10 +0100
Message-ID	<sGFtf-5jU-15@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The new driver caused a rare randconfig failure:

drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0xc): undefined reference to `fb_sys_read'
drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0x10): undefined reference to `fb_sys_write'

This selects the respective helper module, like all other
such drivers do.

Fixes: 8992da44c680 ("auxdisplay: ht16k33: Driver for LED controller")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/auxdisplay/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
index a230ea797b92..b8bbfc64a1d1 100644
--- a/drivers/auxdisplay/Kconfig
+++ b/drivers/auxdisplay/Kconfig
@@ -131,6 +131,7 @@ config IMG_ASCII_LCD
 config HT16K33
 	tristate "Holtek Ht16K33 LED controller with keyscan"
 	depends on FB && OF && I2C && INPUT
+	select FB_SYS_FOPS
 	select INPUT_MATRIXKMAP
 	select FB_BACKLIGHT
 	help
-- 
2.9.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS Arnd Bergmann <arnd@arndb.de> - 2016-11-23 14:10 +0100
  Re: [PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS Robin van der Gracht <robin@protonic.nl> - 2016-11-25 09:00 +0100
    Re: [PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS Arnd Bergmann <arnd@arndb.de> - 2016-11-25 09:40 +0100

csiph-web