Re: [PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS
Date	2016-11-25 09:40 +0100
Message-ID	<sHkd5-6Ft-71@gated-at.bofh.it> (permalink)
References	<sGFtf-5jU-15@gated-at.bofh.it> <sHjAq-68F-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Friday, November 25, 2016 8:50:04 AM CET Robin van der Gracht wrote:
> 
> Thanks for reporting this. You are right about the missing helper.
> However, the fb_ops struct uses several helpers which are all missing.
> 
> static struct fb_ops ht16k33_fb_ops = {
>         .owner = THIS_MODULE,
>         .fb_read = fb_sys_read,
>         .fb_write = fb_sys_write,
>         .fb_fillrect = sys_fillrect,
>         .fb_copyarea = sys_copyarea,
>         .fb_imageblit = sys_imageblit,
>         .fb_mmap = ht16k33_mmap,
> };
> 
> HT16K33 should also select:
> FB_CFB_FILLRECT
> FB_CFB_COPYAREA
> FB_CFB_IMAGEBLIT
> 

Ah right. I had not run into those so far during randconfig
testing, probably because there is usually at least one other
framebuffer enabled that selects them.

Can you submit a patch to add all those?

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS Arnd Bergmann <arnd@arndb.de> - 2016-11-23 14:10 +0100
  Re: [PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS Robin van der Gracht <robin@protonic.nl> - 2016-11-25 09:00 +0100
    Re: [PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS Arnd Bergmann <arnd@arndb.de> - 2016-11-25 09:40 +0100

csiph-web