Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources

From	Milo Kim <woogyom.kim@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources
Date	2016-11-23 14:10 +0100
Message-ID	<sGFtf-5jU-1@gated-at.bofh.it> (permalink)
References	<sFWFP-1DY-1@gated-at.bofh.it> <sGlEe-BN-19@gated-at.bofh.it> <sGE49-4fv-13@gated-at.bofh.it> <sGEnv-4ne-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/23/2016 08:51 PM, Arnd Bergmann wrote:
> Ah, the numbers come from the data sheet. Please just remove the
> header then, there is no need to keep them as an ABI, in particular
> when the driver doesn't even include that header today.

Got it.

> What matters here is the binding documentation in
> Documentation/devicetree/bindings/power/supply/tps65217_charger.txt

OK, in addition to this, the interrupt specifier needs to be added in 
Documentation/devicetree/bindings/input/tps65218-pwrbutton.txt.

> Please fix that instead to mandate that the two interrupts are
> required, what their functions are, and what the interrupt-names
> (not interrupts-names) property must list.

Oops, wrong interrupt name property - my bad.

Thanks for all your feedback.

Best regards,
Milo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources Milo Kim <woogyom.kim@gmail.com> - 2016-11-21 14:20 +0100
  Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217  interrupt sources Lee Jones <lee.jones@linaro.org> - 2016-11-22 17:00 +0100
    Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources Arnd Bergmann <arnd@arndb.de> - 2016-11-22 22:10 +0100
  Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217  interrupt sources Lee Jones <lee.jones@linaro.org> - 2016-11-22 17:00 +0100
    Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217  interrupt sources Milo Kim <woogyom.kim@gmail.com> - 2016-11-23 12:40 +0100
      Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources Arnd Bergmann <arnd@arndb.de> - 2016-11-23 13:00 +0100
        Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217  interrupt sources Milo Kim <woogyom.kim@gmail.com> - 2016-11-23 14:10 +0100

csiph-web