Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1528341

Re: [PATCH 2/5] power: supply: tps65217: Remove IRQ data from driver data

From Milo Kim <woogyom.kim@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/5] power: supply: tps65217: Remove IRQ data from driver data
Date 2016-11-23 12:50 +0100
Message-ID <sGEdQ-4jn-5@gated-at.bofh.it> (permalink)
References <sDLOy-5pg-19@gated-at.bofh.it> <sDLOy-5pg-27@gated-at.bofh.it> <sGmAm-1lo-15@gated-at.bofh.it> <sGmAn-1lo-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 11/23/2016 01:58 AM, Sebastian Reichel wrote:
> On Tue, Nov 22, 2016 at 05:51:07PM +0100, Sebastian Reichel wrote:
>> > On Tue, Nov 15, 2016 at 10:18:52PM +0900, Milo Kim wrote:
>>> > > IRQ number is only used on requesting the interrupt, so no need to keep
>>> > > it inside the driver data.
> Please move simple cleanup patches like this one to the
> begin of the patch series.
>
>>> > > In case of polling, poll_task is valid only when polling thread is
>>> > > activated.
> And merge this change into the patch were you introduced the
> problem...

Thanks for your feedback. Let me regenerate the patch-set for better review.

Best regards,
Milo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] power: supply: tps65217: Support USB charger feature Milo Kim <woogyom.kim@gmail.com> - 2016-11-15 14:20 +0100
  [PATCH 5/5] power: supply: tps65217: Use generic name for power supply structures Milo Kim <woogyom.kim@gmail.com> - 2016-11-15 14:20 +0100
  [PATCH 2/5] power: supply: tps65217: Remove IRQ data from driver data Milo Kim <woogyom.kim@gmail.com> - 2016-11-15 14:20 +0100
    Re: [PATCH 2/5] power: supply: tps65217: Remove IRQ data from driver  data Sebastian Reichel <sre@kernel.org> - 2016-11-22 18:00 +0100
      Re: [PATCH 2/5] power: supply: tps65217: Remove IRQ data from driver  data Sebastian Reichel <sre@kernel.org> - 2016-11-22 18:00 +0100
        Re: [PATCH 2/5] power: supply: tps65217: Remove IRQ data from driver  data Milo Kim <woogyom.kim@gmail.com> - 2016-11-23 12:50 +0100
  [PATCH 4/5] power: supply: tps65217: Use generic name for charger online Milo Kim <woogyom.kim@gmail.com> - 2016-11-15 14:20 +0100
  [PATCH 1/5] power: supply: tps65217: Move IRQ related operation into single function Milo Kim <woogyom.kim@gmail.com> - 2016-11-15 14:30 +0100
    Re: [PATCH 1/5] power: supply: tps65217: Move IRQ related operation  into single function Sebastian Reichel <sre@kernel.org> - 2016-11-22 18:00 +0100
      Re: [PATCH 1/5] power: supply: tps65217: Move IRQ related operation  into single function Sebastian Reichel <sre@kernel.org> - 2016-11-22 18:00 +0100
  [PATCH 3/5] power: supply: tps65217: Support USB charger interrupt Milo Kim <woogyom.kim@gmail.com> - 2016-11-15 14:30 +0100

csiph-web