Groups > linux.kernel > #1519890

Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.unit0.net!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Joerg Roedel <joro@8bytes.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic
Date	Fri, 11 Nov 2016 17:30:01 +0100
Message-ID	<sCmSd-6F5-9@gated-at.bofh.it> (permalink)
References	<sBBTj-8ph-5@gated-at.bofh.it> <sBBTj-8ph-3@gated-at.bofh.it> <sClWa-62H-13@gated-at.bofh.it> <sCmIx-6BV-13@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=simple/simple; d=8bytes.org; s=mail-1; t=1478881656; bh=vltHWk4lqGqQUO7TMV1l1F+Oh4HnS8Ea15PvQW6e5+4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YJwqtDVz1AoyoucLUfqcG614lKqCOLjxuqg+tltkqzA3OGocncQefnsIjM2lnNM+F Kt599ucezhj6b9jBZYStXvYwF3ARbEGKGViS5ShqBIR4pq3Uzhk0xpWzaUbDDGc+ye Pw/C5foTEFKG59skiAUONQQ9+N1Yagke2NMncTFBznR/w/WFFJk1x49UTBRpEhQx++ lEi00ycVNbrJuJZu+QenmMftzSN2ifMbzyaVKwPyQRtRD8jlfeySPCgdxANRL63Nw6 8SjjXPE7oeK8AsEYYH1X7KcX+6LvUytCCbkMeAFYjs2lppd5mq6SSkOQOTK9dTfgk/ WS1YZ2+W7ta9A==
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	19
Organization	linux.* mail to news gateway
X-Original-Cc	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, iommu@lists.linux-foundation.org, Will Deacon <will.deacon@arm.com>, Hanjun Guo <hanjun.guo@linaro.org>, Marc Zyngier <marc.zyngier@arm.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Tomasz Nowicki <tn@semihalf.com>, Jon Masters <jcm@redhat.com>, Eric Auger <eric.auger@redhat.com>, Sinan Kaya <okaya@codeaurora.org>, Nate Watterson <nwatters@codeaurora.org>, Prem Mallappa <prem.mallappa@broadcom.com>, Dennis Chen <dennis.chen@arm.com>, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
X-Original-Date	Fri, 11 Nov 2016 17:27:36 +0100
X-Original-Message-ID	<20161111162736.GV2078@8bytes.org>
X-Original-References	<20161109141948.19244-1-lorenzo.pieralisi@arm.com> <20161109141948.19244-5-lorenzo.pieralisi@arm.com> <20161111152248.GS2078@8bytes.org> <552e674a-f434-f08f-8e16-a94544ce8e6e@arm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1519890

Show key headers only | View raw

On Fri, Nov 11, 2016 at 04:17:37PM +0000, Robin Murphy wrote:
> In the original of_iommu_configure design, the thought was that an ops
> structure could be IOMMU-instance-specific (hence the later-removed
> "priv" member), so I suppose right now it is mostly a hangover from
> that. However, it's also what we initialise a device's fwspec with, so
> becomes important again if we're ever going to get past the limitations
> of buses-which-are-not-actually-buses[1].

Yeah, I discussed this with a few others at LPC. My current idea is to
tell the iommu-core which hardware-iommus exist in the system and a
seperate iommu_ops ptr for each of them. Then every struct device can
link to the iommu-instance it is translated by.

We are not there yet, but this will give you the same per-device
iommu-ops as implemented here.

	Joerg

Thread

[PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-11-09 15:20 +0100
  Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Robin Murphy <robin.murphy@arm.com> - 2016-11-09 15:50 +0100
    Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-11-10 12:20 +0100
  Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Joerg Roedel <joro@8bytes.org> - 2016-11-11 16:30 +0100
    Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Robin Murphy <robin.murphy@arm.com> - 2016-11-11 17:20 +0100
      Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Joerg Roedel <joro@8bytes.org> - 2016-11-11 17:30 +0100
        Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Robin Murphy <robin.murphy@arm.com> - 2016-11-11 18:50 +0100
          Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-11-14 11:30 +0100
            Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Robin Murphy <robin.murphy@arm.com> - 2016-11-14 13:10 +0100
              Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Joerg Roedel <joro@8bytes.org> - 2016-11-14 17:00 +0100
                Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-11-14 17:50 +0100
                Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Robin Murphy <robin.murphy@arm.com> - 2016-11-14 19:30 +0100
                Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-11-15 11:10 +0100
                Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-11-16 11:00 +0100

csiph-web