Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic

From	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic
Date	2016-11-14 17:50 +0100
Message-ID	<sDsCe-12v-25@gated-at.bofh.it> (permalink)
References	(4 earlier) <sCmSd-6F5-9@gated-at.bofh.it> <sCo7E-7kn-1@gated-at.bofh.it> <sDmGu-5IO-31@gated-at.bofh.it> <sDofg-6Oy-53@gated-at.bofh.it> <sDrPQ-sM-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 14, 2016 at 04:52:23PM +0100, Joerg Roedel wrote:
> On Mon, Nov 14, 2016 at 12:00:47PM +0000, Robin Murphy wrote:
> > If we've already made the decision to move away from bus ops, I don't
> > see that it makes sense to deliberately introduce new dependencies on
> > them. Besides, as it stands, this patch literally implements "tell the
> > iommu-core which hardware-iommus exist in the system and a seperate
> > iommu_ops ptr for each of them" straight off.
> 
> Not sure which code you are looking at, but as I see it we have only
> per-device iommu-ops now (with this patch). That is different from
> having core-visible hardware-iommu instances where devices could link
> to.

This patch enables the IOMMU-OF-node<->device look-up on non-OF (ie
ACPI) systems by "converting" the of_node to a generic fwnode_handle,
that's all it does (and move the related look-up code from
drivers/iommu/of_iommu.c to drivers/iommu/iommu.c so that it does
not depend on OF_IOMMU any longer).

> Also the rest of iommu-core code still makes use of the per-bus ops. The
> per-device ops are only used for the of_xlate fn-ptr.

I can put this patch on the backburner and retrieve the iommu_ops
through the dev->bus path in the IORT xlate function (iort_iommu_xlate()
introduced in the last patch), the change is trivial and should work
just fine but it deserves a v8 to give everyone a chance to test it.

We would end-up handling the device->iommu_ops look-up differently in DT
and ACPI for streamid translations though, I am not sure I see a reason
why.

Thanks,
Lorenzo

Thread

Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-11-14 11:30 +0100
  Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Robin Murphy <robin.murphy@arm.com> - 2016-11-14 13:10 +0100
    Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Joerg Roedel <joro@8bytes.org> - 2016-11-14 17:00 +0100
      Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-11-14 17:50 +0100
      Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Robin Murphy <robin.murphy@arm.com> - 2016-11-14 19:30 +0100
        Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-11-15 11:10 +0100
        Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT  agnostic Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-11-16 11:00 +0100

csiph-web