Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1519886
| From | Robin Murphy <robin.murphy@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic |
| Date | 2016-11-11 17:20 +0100 |
| Message-ID | <sCmIx-6BV-13@gated-at.bofh.it> (permalink) |
| References | <sBBTj-8ph-5@gated-at.bofh.it> <sBBTj-8ph-3@gated-at.bofh.it> <sClWa-62H-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 11/11/16 15:22, Joerg Roedel wrote:
> On Wed, Nov 09, 2016 at 02:19:36PM +0000, Lorenzo Pieralisi wrote:
>> +struct iommu_fwentry {
>> + struct list_head list;
>> + struct fwnode_handle *fwnode;
>> + const struct iommu_ops *ops;
>> +};
>
> Is there a reason the iommu_ops need to be stored there? Currently it
> seems that the ops are only needed to get the of_xlate fn-ptr later. And
> the place where it is called the iommu-ops should also be available
> through pdev->dev->bus->iommu_ops.
In the original of_iommu_configure design, the thought was that an ops
structure could be IOMMU-instance-specific (hence the later-removed
"priv" member), so I suppose right now it is mostly a hangover from
that. However, it's also what we initialise a device's fwspec with, so
becomes important again if we're ever going to get past the limitations
of buses-which-are-not-actually-buses[1].
Robin.
[1]:http://www.mail-archive.com/iommu@lists.linux-foundation.org/msg14576.html
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-11-09 15:20 +0100
Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic Robin Murphy <robin.murphy@arm.com> - 2016-11-09 15:50 +0100
Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-11-10 12:20 +0100
Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic Joerg Roedel <joro@8bytes.org> - 2016-11-11 16:30 +0100
Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic Robin Murphy <robin.murphy@arm.com> - 2016-11-11 17:20 +0100
Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic Joerg Roedel <joro@8bytes.org> - 2016-11-11 17:30 +0100
Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic Robin Murphy <robin.murphy@arm.com> - 2016-11-11 18:50 +0100
Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-11-14 11:30 +0100
Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic Robin Murphy <robin.murphy@arm.com> - 2016-11-14 13:10 +0100
Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic Joerg Roedel <joro@8bytes.org> - 2016-11-14 17:00 +0100
Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-11-14 17:50 +0100
Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic Robin Murphy <robin.murphy@arm.com> - 2016-11-14 19:30 +0100
Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-11-15 11:10 +0100
Re: [PATCH v7 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-11-16 11:00 +0100
csiph-web