Groups > linux.kernel > #1519700

Re: [PATCH v4 1/5] arm64: perf: Basic uncore counter support for Cavium ThunderX SOC

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/5] arm64: perf: Basic uncore counter support for Cavium ThunderX SOC
Date	2016-11-11 12:20 +0100
Message-ID	<sCi2d-3Bo-15@gated-at.bofh.it> (permalink)
References	<sxAsN-5HA-5@gated-at.bofh.it> <sxAsN-5HA-7@gated-at.bofh.it> <sC0RN-ke-17@gated-at.bofh.it> <sCi2d-3Bo-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Nov 11, 2016 at 11:39:21AM +0100, Jan Glauber wrote:
> Hi Mark,
> 
> thanks for reviewing. One question below,

> On Thu, Nov 10, 2016 at 04:54:06PM +0000, Mark Rutland wrote:

> > On Sat, Oct 29, 2016 at 01:55:29PM +0200, Jan Glauber wrote:

> > > +#include <linux/cpufeature.h>
> > > +#include <linux/numa.h>
> > > +#include <linux/slab.h>
> > 
> > I believe the following includes are necessary for APIs and/or data
> > explicitly referenced by the driver code:

[...]

> Should I also add includes that are already in the included by uncore_cavium.h?

Please do.

> I usually avoid includes that come through the "local" header file.

Generally, when you explcitly use some macro/function/data in a file,
that file should have the relevant include. 

If something's only used in the header (e.g. hidden in a macro or inline
function), then we only need that include in the header.

For example: uncore_cavium.h uses container_of(), and should include
<linux/kernel.h>. Also, uncore_cavium.c also uses container_of()
directly for something unrelated, and should also include
<linux/kernel.h>.

Thanks,
Mark.

Thread

[PATCH v4 0/5] Cavium ThunderX uncore PMU support  Jan Glauber <jglauber@cavium.com> - 2016-10-29 14:00 +0200
  [PATCH v4 5/5] arm64: perf: Cavium ThunderX OCX TLK uncore support Jan Glauber <jglauber@cavium.com> - 2016-10-29 14:00 +0200
  [PATCH v4 1/5] arm64: perf: Basic uncore counter support for Cavium ThunderX SOC Jan Glauber <jglauber@cavium.com> - 2016-10-29 14:00 +0200
    Re: [PATCH v4 1/5] arm64: perf: Basic uncore counter support for  Cavium ThunderX SOC Will Deacon <will.deacon@arm.com> - 2016-11-09 01:00 +0100
      Re: [PATCH v4 1/5] arm64: perf: Basic uncore counter support for  Cavium ThunderX SOC Will Deacon <will.deacon@arm.com> - 2016-11-17 19:20 +0100
    Re: [PATCH v4 1/5] arm64: perf: Basic uncore counter support for  Cavium ThunderX SOC Mark Rutland <mark.rutland@arm.com> - 2016-11-10 18:00 +0100
      Re: [PATCH v4 1/5] arm64: perf: Basic uncore counter support for  Cavium ThunderX SOC Will Deacon <will.deacon@arm.com> - 2016-11-10 20:50 +0100
      Re: [PATCH v4 1/5] arm64: perf: Basic uncore counter support for  Cavium ThunderX SOC Mark Rutland <mark.rutland@arm.com> - 2016-11-11 12:20 +0100
  [PATCH v4 3/5] arm64: perf: Cavium ThunderX L2C CBC uncore support Jan Glauber <jglauber@cavium.com> - 2016-10-29 14:00 +0200
  [PATCH v4 4/5] arm64: perf: Cavium ThunderX LMC uncore support Jan Glauber <jglauber@cavium.com> - 2016-10-29 14:00 +0200

csiph-web