Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1524683
| From | Will Deacon <will.deacon@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 1/5] arm64: perf: Basic uncore counter support for Cavium ThunderX SOC |
| Date | 2016-11-17 19:20 +0100 |
| Message-ID | <sEzrZ-4eD-73@gated-at.bofh.it> (permalink) |
| References | <sxAsN-5HA-5@gated-at.bofh.it> <sxAsN-5HA-7@gated-at.bofh.it> <sBot3-7V7-7@gated-at.bofh.it> <sEzrZ-4eD-75@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Nov 11, 2016 at 11:30:29AM +0100, Jan Glauber wrote:
> On Tue, Nov 08, 2016 at 11:50:10PM +0000, Will Deacon wrote:
> > On Sat, Oct 29, 2016 at 01:55:29PM +0200, Jan Glauber wrote:
> > > +/* node attribute depending on number of NUMA nodes */
> > > +static ssize_t node_show(struct device *dev, struct device_attribute *attr,
> > > + char *page)
> > > +{
> > > + if (NODES_SHIFT)
> > > + return sprintf(page, "config:16-%d\n", 16 + NODES_SHIFT - 1);
> >
> > If NODES_SHIFT is 1, you'll end up with "config:16-16", which might confuse
> > userspace.
>
> So should I use "config:16" in that case? Is it OK to use this also for
> NODES_SHIFT=0 ?
If you only need one bit, then "config:16" is the right thing to do.
Will
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH v4 1/5] arm64: perf: Basic uncore counter support for Cavium ThunderX SOC Will Deacon <will.deacon@arm.com> - 2016-11-17 19:20 +0100
csiph-web