Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1519052

Re: [PATCH v1 1/1] mfd: intel-lpss: Try to enable Memory-Write-Invalidate

Path csiph.com!news.redatomik.org!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v1 1/1] mfd: intel-lpss: Try to enable Memory-Write-Invalidate
Date Thu, 10 Nov 2016 16:30:01 +0100
Message-ID <sBZsB-7Yu-5@gated-at.bofh.it> (permalink)
References <sBYZA-7y9-27@gated-at.bofh.it> <sBZ9g-7QM-25@gated-at.bofh.it>
X-Original-To Mika Westerberg <mika.westerberg@linux.intel.com>
X-Extloop1 1
X-Ironport-Av E=Sophos;i="5.31,619,1473145200"; d="scan'208";a="899995661"
Organization Intel Finland Oy
Content-Type text/plain; charset="UTF-8"
X-Mailer Evolution 3.22.1-1
MIME-Version 1.0
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 18
X-Original-Cc Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org
X-Original-Date Thu, 10 Nov 2016 17:22:40 +0200
X-Original-Message-ID <1478791360.5295.119.camel@linux.intel.com>
X-Original-References <20161110145142.159911-1-andriy.shevchenko@linux.intel.com> <20161110145930.GL1470@lahna.fi.intel.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1519052

Show key headers only | View raw


On Thu, 2016-11-10 at 16:59 +0200, Mika Westerberg wrote:
> On Thu, Nov 10, 2016 at 04:51:42PM +0200, Andy Shevchenko wrote:
> > Enable MWI mechanism if PCI bus master supports it.
> 
> Why?

It might be potential benefit in some cases. Documentation says that
standard Memory Write might supply more current data than in the CPU
modified cache line and "trashing a line in the cache may trash some
data that is more current that in the memory line". This allows to avoid
potential retries and other performance degradation issues on the bus.
Though, I dunno how to measure it.

Would be enough to extend commit message by this paragraph?

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v1 1/1] mfd: intel-lpss: Try to enable Memory-Write-Invalidate Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-11-10 16:00 +0100
  Re: [PATCH v1 1/1] mfd: intel-lpss: Try to enable  Memory-Write-Invalidate Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-11-10 16:10 +0100
    Re: [PATCH v1 1/1] mfd: intel-lpss: Try to enable  Memory-Write-Invalidate Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-11-10 16:30 +0100
      Re: [PATCH v1 1/1] mfd: intel-lpss: Try to enable  Memory-Write-Invalidate Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-11-10 17:50 +0100

csiph-web