Re: [PATCH v2 1/2] cpufreq: add new attribute type cpufreq_freq_attr_wr_perm()

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] cpufreq: add new attribute type cpufreq_freq_attr_wr_perm()
Date	2016-11-07 05:40 +0100
Message-ID	<sAJSV-6w9-1@gated-at.bofh.it> (permalink)
References	<szQ0q-4l3-3@gated-at.bofh.it> <szQ0q-4l3-1@gated-at.bofh.it> <sAJSV-6w9-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07-11-16, 10:03, Viresh Kumar wrote:
> On 04-11-16, 09:55, Markus Mayer wrote:
> > From: Markus Mayer <mmayer@broadcom.com>
> > 
> > With the new attribute type, it is possible to create write-only
> > CPUfreq attributes.
> > 
> > Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> > ---
> >  include/linux/cpufreq.h | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> > index 5fa55fc..ed09930 100644
> > --- a/include/linux/cpufreq.h
> > +++ b/include/linux/cpufreq.h
> > @@ -234,6 +234,10 @@ __ATTR(_name, _perm, show_##_name, NULL)
> >  static struct freq_attr _name =			\
> >  __ATTR(_name, 0644, show_##_name, store_##_name)
> >  
> > +#define cpufreq_freq_attr_wr_perm(_name, _perm)	\
> 
> shouldn't this be _wo_perm ?
> 
> Also, I wouldn't mind doing this in the second patch itself.

Also there is no need to define a _perm variant here, and then you can avoid
sending 0200 as argument as well.

-- 
viresh

Thread

[PATCH v2 1/2] cpufreq: add new attribute type cpufreq_freq_attr_wr_perm() Markus Mayer <code@mmayer.net> - 2016-11-04 18:00 +0100
  Re: [PATCH v2 1/2] cpufreq: add new attribute type  cpufreq_freq_attr_wr_perm() Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-07 05:40 +0100
  Re: [PATCH v2 1/2] cpufreq: add new attribute type  cpufreq_freq_attr_wr_perm() Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-07 06:40 +0100

csiph-web