Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1466697
| Path | csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Jiri Kosina <jikos@kernel.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] net: sched: avoid duplicates in qdisc dump |
| Date | Fri, 19 Aug 2016 23:50:02 +0200 |
| Message-ID | <s7ZPQ-2zI-11@gated-at.bofh.it> (permalink) |
| References | <s6UyR-8k-9@gated-at.bofh.it> <s6UyS-8k-15@gated-at.bofh.it> <s7H6x-7vO-5@gated-at.bofh.it> |
| X-Original-To | Cong Wang <xiyou.wangcong@gmail.com> |
| X-X-Sender | jkosina@pobox.suse.cz |
| User-Agent | Alpine 2.00 (LNX 1167 2008-08-23) |
| MIME-Version | 1.0 |
| Content-Type | TEXT/PLAIN; charset=US-ASCII |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 23 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | David Miller <davem@davemloft.net>, Daniel Borkmann <daniel@iogearbox.net>, David Ahern <dsa@cumulusnetworks.com>, Simon Horman <simon.horman@netronome.com>, Eric Dumazet <eric.dumazet@gmail.com>, Jamal Hadi Salim <jhs@mojatatu.com>, Phil Sutter <phil@nwl.cc>, LKML <linux-kernel@vger.kernel.org>, Linux Kernel Network Developers <netdev@vger.kernel.org> |
| X-Original-Date | Fri, 19 Aug 2016 23:48:14 +0200 (CEST) |
| X-Original-Message-ID | <alpine.LNX.2.00.1608192343480.22028@cbobk.fhfr.pm> |
| X-Original-References | <alpine.LNX.2.00.1608162339050.22028@cbobk.fhfr.pm> <alpine.LNX.2.00.1608162350330.22028@cbobk.fhfr.pm> <CAM_iQpW9QOADkzDDEGYjTNnW21uwHX5xFx1iX=Wio5=i34kDbQ@mail.gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1466697 |
Show key headers only | View raw
On Thu, 18 Aug 2016, Cong Wang wrote: > Doesn't this mean we can now just remove the ingress case from > tc_dump_qdisc() and simply iterate the whole hash table? That'd be indeed a nice cleanup, but for that we'll have to make sure that the top-level ingress entry makes it to the hashtable as well; that's not the case currently, and hence the special-casing (but I agree that it's in principle just a remnant of the old design and of a rather 1:1 list->hashtable conversion, and there is no good reason for keeping it this way any more). So patch that'd add ingress qdisc to the hashtable whenever it materializes should be enough to get rid of the "we have to walk two linked lists" heritage and the ingress special-casing for dumps. Will look into it next week unless someone is faster. Thanks, -- Jiri Kosina SUSE Labs
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH next-next 0/2] qdisc-hashtable fixes Jiri Kosina <jikos@kernel.org> - 2016-08-17 00:00 +0200
[PATCH 2/2] net: sched: avoid duplicates in qdisc dump Jiri Kosina <jikos@kernel.org> - 2016-08-17 00:00 +0200
Re: [PATCH 2/2] net: sched: avoid duplicates in qdisc dump Cong Wang <xiyou.wangcong@gmail.com> - 2016-08-19 03:50 +0200
Re: [PATCH 2/2] net: sched: avoid duplicates in qdisc dump Jiri Kosina <jikos@kernel.org> - 2016-08-19 23:50 +0200
[PATCH 1/2] net: sched: fix handling of singleton qdiscs with qdisc_hash Jiri Kosina <jikos@kernel.org> - 2016-08-17 00:00 +0200
Re: [PATCH next-next 0/2] qdisc-hashtable fixes David Miller <davem@davemloft.net> - 2016-08-19 06:20 +0200
csiph-web